Bug 44029 - Chromium DevTools: There is no need in resource-based InjectedScript.js source.
Summary: Chromium DevTools: There is no need in resource-based InjectedScript.js source.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-15 05:47 PDT by Pavel Feldman
Modified: 2010-08-19 07:48 PDT (History)
2 users (show)

See Also:


Attachments
[PATCH] Proposed change. (2.53 KB, patch)
2010-08-15 05:52 PDT, Pavel Feldman
yurys: review-
Details | Formatted Diff | Diff
[PATCH] Reviewer comments addressed. (5.03 KB, patch)
2010-08-19 03:25 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff
[PATCH] Same with DRT. (8.63 KB, patch)
2010-08-19 07:17 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-08-15 05:47:57 PDT
Now that we populate front-end after its onload handler, I don't think we need to install injected script early.
Comment 1 Pavel Feldman 2010-08-15 05:52:46 PDT
Created attachment 64446 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2010-08-16 01:19:22 PDT
Comment on attachment 64446 [details]
[PATCH] Proposed change.

WebKit/chromium/ChangeLog:7
 +          to install injected script early.
InjectedScript source isn't pushed when inspected tab is navigated to a different domain and because of that resides in a new render process(we won't send the script source to that process).
Comment 3 Pavel Feldman 2010-08-19 03:25:27 PDT
Created attachment 64825 [details]
[PATCH] Reviewer comments addressed.
Comment 4 Pavel Feldman 2010-08-19 07:17:56 PDT
Created attachment 64845 [details]
[PATCH] Same with DRT.
Comment 5 Pavel Feldman 2010-08-19 07:48:28 PDT
Comment on attachment 64845 [details]
[PATCH] Same with DRT.

Clearing flags on attachment: 64845

Committed r65669: <http://trac.webkit.org/changeset/65669>
Comment 6 Pavel Feldman 2010-08-19 07:48:41 PDT
All reviewed patches have been landed.  Closing bug.