RESOLVED FIXED 44028
Web Inspector: Make InjectedScript proto-based. 
https://bugs.webkit.org/show_bug.cgi?id=44028
Summary Web Inspector: Make InjectedScript proto-based.
Pavel Feldman
Reported 2010-08-15 05:39:48 PDT
As a part of a 'better protocol' initiative, I am re-thinking the InjectedScript exposure. My present thinking is that InspectorDebugAgent (or new InspectorRuntimeAgent) will have 'installFunction' and 'evaluateInWindow' methods. Front-ends will install whatever functions they want into the injected script (like ours will install "getCompletions" and "getPrototypes"). The only functionality that will be 'pre-installed' in injected script is going to be wrapping and unwrapping of objects. Here is the first step towards that goal.
Attachments
[PATCH] Proposed change. (38.28 KB, patch)
2010-08-15 05:45 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-08-15 05:45:58 PDT
Created attachment 64445 [details] [PATCH] Proposed change.
Yury Semikhatsky
Comment 2 2010-08-16 01:09:28 PDT
Comment on attachment 64445 [details] [PATCH] Proposed change. WebCore/inspector/front-end/InjectedScript.js:44 + result.type = typeof object; Please construct the result using a factory method on InjectedScript.RemoteObject like you do in other places. WebCore/ChangeLog:6 + https://bugs.webkit.org/show_bug.cgi?id=44028 Please add meaningful description for semantic changes in this patch, they are very hard to track among code formatting changes. WebCore/ChangeLog:5 + Web Inspector: Make InjectedScript proto-based. How does this change relate to the final goal of reducing number of predefined methods on the InjectedScript and introducing installFunction? We may well have installFunction defined on the InjectedScript instance as there is anyway the only one.
Pavel Feldman
Comment 3 2010-08-16 05:20:14 PDT
Comment on attachment 64445 [details] [PATCH] Proposed change. Clearing flags on attachment: 64445 Committed r65414: <http://trac.webkit.org/changeset/65414>
Pavel Feldman
Comment 4 2010-08-16 05:20:28 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-08-16 06:03:18 PDT
http://trac.webkit.org/changeset/65414 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/65414 http://trac.webkit.org/changeset/65415
Csaba Osztrogonác
Comment 6 2010-08-16 07:03:58 PDT
Reopen, because it was rolled out by http://trac.webkit.org/changeset/65423
Pavel Feldman
Comment 7 2010-08-16 09:34:38 PDT
This has been rolled out and re-landed with the console test fixed (test had a race condition): Committing to http://svn.webkit.org/repository/webkit/trunk ... D LayoutTests/http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js M LayoutTests/ChangeLog M LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt M LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.html M LayoutTests/http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r65434
Note You need to log in before you can comment on or make changes to this bug.