Patch to follow.
Regresed in r63891.
Created attachment 64443 [details] [PATCH] Proposed fix.
Created attachment 64444 [details] [PATCH] Same with proper test title.
Any particular reason we wait for a callback to clear the UI? I don't see a purpose to the consoleMessagesCleared notification. I'd rather the UI clear instantly. Am I missing something, or are we just being consistent and letting every backend message have some kind of callback? Looks good to me, I just have this question.
This bug should have stated more clearly that it is about clear() command in the console not working. We initiate clear from injected script (backend) in case of command line api use. So we need to send a direct message to the frontend. Easy to forget - same happened to Yury. So I added a test.
Comment on attachment 64444 [details] [PATCH] Same with proper test title. (In reply to comment #5) > This bug should have stated more clearly that it is about clear() command > in the console not working. My fault. Its entirely clear from the bug's title, I just overlooked it! > We initiate clear from injected script (backend) in case of command line > api use. So we need to send a direct message to the frontend. Easy to forget > - same happened to Yury. So I added a test. Haha, you're right its easy to forget =). Good fix and nice test. r=me
Comment on attachment 64444 [details] [PATCH] Same with proper test title. Clearing flags on attachment: 64444 Committed r65412: <http://trac.webkit.org/changeset/65412>
All reviewed patches have been landed. Closing bug.