Bug 44020 – [EFL] Enable localStorage of HTML5 for WebKit EFL

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

Let's enable localStorage of HTML5.

[Gyuyoung Kim]

Created attachment 64435 [details]
Patch

I invoke setLocalStorageEnabled() in _ewk_view_priv_new() as below,

 26      priv->page_settings->setPluginsEnabled(true);
 27 +    priv->page_settings->setLocalStorageEnabled(true);

BTW, it seems we need to set the initial settings values dynamically.

[Antonio Gomes]

> BTW, it seems we need to set the initial settings values dynamically.

what do you mean?

[WebKit Commit Bot]

Comment on attachment 64435 [details]
Patch

Clearing flags on attachment: 64435

Committed r65380: <http://trac.webkit.org/changeset/65380>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/65380 might have broken SnowLeopard Intel Release (Tests)

[Gyuyoung Kim]

(In reply to comment #2)
> > BTW, it seems we need to set the initial settings values dynamically.
> 
> what do you mean?

I mean that default settings below is hardcoded.

static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* sd) {
...
priv->page_settings->setLoadsImagesAutomatically(true);
priv->page_settings->setDefaultFixedFontSize(12);
priv->page_settings->setDefaultFontSize(16);
priv->page_settings->setSerifFontFamily("serif");
priv->page_settings->setFixedFontFamily("monotype");
priv->page_settings->setSansSerifFontFamily("sans");
priv->page_settings->setStandardFontFamily("sans");
priv->page_settings->setJavaScriptEnabled(true);
priv->page_settings->setPluginsEnabled(true);
priv->page_settings->setLocalStorageEnabled(true);
...
}

It seems to me the default values need to be changed by setting file or user and so on. How do you think about it ?

[Antonio Gomes]

(In reply to comment #6)
> (In reply to comment #2)
> > > BTW, it seems we need to set the initial settings values dynamically.
> > 
> > what do you mean?
> 
> I mean that default settings below is hardcoded.
> 
> static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* sd) {
> ...
> priv->page_settings->setLoadsImagesAutomatically(true);
> priv->page_settings->setDefaultFixedFontSize(12);
> priv->page_settings->setDefaultFontSize(16);
> priv->page_settings->setSerifFontFamily("serif");
> priv->page_settings->setFixedFontFamily("monotype");
> priv->page_settings->setSansSerifFontFamily("sans");
> priv->page_settings->setStandardFontFamily("sans");
> priv->page_settings->setJavaScriptEnabled(true);
> priv->page_settings->setPluginsEnabled(true);
> priv->page_settings->setLocalStorageEnabled(true);
> ...
> }
> 
> It seems to me the default values need to be changed by setting file or user and so on. How do you think about it ?

I agree. Maybe a EWebSettings public class to your API(?)

[Gyuyoung Kim]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #2)
> > > > BTW, it seems we need to set the initial settings values dynamically.
> > > 
> > > what do you mean?
> > 
> > I mean that default settings below is hardcoded.
> > 
> > static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* sd) {
> > ...
> > priv->page_settings->setLoadsImagesAutomatically(true);
> > priv->page_settings->setDefaultFixedFontSize(12);
> > priv->page_settings->setDefaultFontSize(16);
> > priv->page_settings->setSerifFontFamily("serif");
> > priv->page_settings->setFixedFontFamily("monotype");
> > priv->page_settings->setSansSerifFontFamily("sans");
> > priv->page_settings->setStandardFontFamily("sans");
> > priv->page_settings->setJavaScriptEnabled(true);
> > priv->page_settings->setPluginsEnabled(true);
> > priv->page_settings->setLocalStorageEnabled(true);
> > ...
> > }
> > 
> > It seems to me the default values need to be changed by setting file or user and so on. How do you think about it ?
> 
> I agree. Maybe a EWebSettings public class to your API(?)

Ok, I will consider how to modify this issue.