Bug 44017 - XSLTProcessor.transformToFragment should not pass contextElement to the parser (since there is no context)
Summary: XSLTProcessor.transformToFragment should not pass contextElement to the parse...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-14 16:00 PDT by Eric Seidel (no email)
Modified: 2010-08-14 16:30 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2010-08-14 16:02 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-08-14 16:00:33 PDT 
XSLTProcessor.transformToFragment should not pass contextElement
Comment 1 Eric Seidel (no email) 2010-08-14 16:02:50 PDT 
Created attachment 64432 [details]
Patch
Comment 2 Adam Barth 2010-08-14 16:08:53 PDT 
Comment on attachment 64432 [details]
Patch

WebCore/xml/XSLTProcessor.cpp:103
 +          fragment->parseHTML(sourceString, 0);
I don't get this part of the change.  Who passes a non-zero argument?
Comment 3 Adam Barth 2010-08-14 16:11:42 PDT 
Comment on attachment 64432 [details]
Patch

Thanks for explaining on IRC.  We should probably have two methods with different names since they're semantically different.
Comment 4 Eric Seidel (no email) 2010-08-14 16:13:27 PDT 
the contextElement is an optional parameter to the parse (at least in HTML5).  The Xml parser should work similarly.
Comment 5 WebKit Commit Bot 2010-08-14 16:30:03 PDT 
Comment on attachment 64432 [details]
Patch

Clearing flags on attachment: 64432

Committed r65375: <http://trac.webkit.org/changeset/65375>
Comment 6 WebKit Commit Bot 2010-08-14 16:30:08 PDT 
All reviewed patches have been landed.  Closing bug.