Bug 44011 - Move innerHTML off of Range::createContextualFragment
Summary: Move innerHTML off of Range::createContextualFragment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-14 09:23 PDT by Eric Seidel (no email)
Modified: 2010-08-14 14:51 PDT (History)
4 users (show)

See Also:


Attachments
Patch (12.55 KB, patch)
2010-08-14 09:40 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (13.86 KB, patch)
2010-08-14 14:02 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-08-14 09:23:15 PDT
Move innerHTML off of Range::createContextualFragment
Comment 1 Eric Seidel (no email) 2010-08-14 09:40:51 PDT
Created attachment 64419 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-08-14 09:42:27 PDT
diff seems to have made this patch way more confusing than it needs to be.  This is all just removing html5TreeBuilder if blocks around some code in createContextualFragment, and adding new if blocks in innerHTML and outerHTML.
Comment 3 Eric Seidel (no email) 2010-08-14 11:11:55 PDT
Comment on attachment 64419 [details]
Patch

This instead broke the XML innerHTML code path.  Will fix.
Comment 4 Eric Seidel (no email) 2010-08-14 14:02:08 PDT
Created attachment 64427 [details]
Patch
Comment 5 Adam Barth 2010-08-14 14:05:29 PDT
Comment on attachment 64427 [details]
Patch

Ok.  These stuff is somewhat messy after this patch (ok, it was messy before), but we're making progress.
Comment 6 WebKit Commit Bot 2010-08-14 14:39:14 PDT
Comment on attachment 64427 [details]
Patch

Clearing flags on attachment: 64427

Committed r65372: <http://trac.webkit.org/changeset/65372>
Comment 7 WebKit Commit Bot 2010-08-14 14:39:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2010-08-14 14:51:45 PDT
http://trac.webkit.org/changeset/65372 might have broken Qt Linux Release minimal