These two tests fail because of r65340: fast/forms/state-restore-to-non-autocomplete-form.html fast/forms/state-restore-to-non-edited-controls.html This is most likely because we do this in an inline <script> tag: 41 // Submit form in a timeout to make sure that we create a new back/forward list item. 42 setTimeout(function() {document.getElementById('form2').submit();}, 0); However, even with the timeout 0, that may happen before onload fires (as far as targetFrame->loader()->documentLoader()->isLoadingInAPISense()) is concerned). Moving those submits to in the onload handler (still with the setTimeout wrapper) seeems like a good idea.
Created attachment 64392 [details] Patch
Comment on attachment 64392 [details] Patch ok.
Attachment 64392 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 64392 [details] Patch style elf says no.
Created attachment 64394 [details] Patch
Comment on attachment 64394 [details] Patch aight.
Comment on attachment 64392 [details] Patch Rejecting patch 64392 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 64392, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: 4392&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=43998&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 64392 from bug 43998. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment on attachment 64394 [details] Patch Clearing flags on attachment: 64394 Committed r65348: <http://trac.webkit.org/changeset/65348>
All reviewed patches have been landed. Closing bug.