Bug 43998 - Form state restore tests fail on GTK build with r65340
Summary: Form state restore tests fail on GTK build with r65340
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Mihai Parparita
Depends on:
Reported: 2010-08-13 17:47 PDT by Mihai Parparita
Modified: 2010-08-13 19:17 PDT (History)
4 users (show)

See Also:

Patch (8.02 KB, patch)
2010-08-13 18:05 PDT, Mihai Parparita
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (8.02 KB, patch)
2010-08-13 18:16 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-08-13 17:47:14 PDT
These two tests fail because of r65340:


This is most likely because we do this in an inline <script> tag:

41	    // Submit form in a timeout to make sure that we create a new back/forward list item.           
42	    setTimeout(function() {document.getElementById('form2').submit();}, 0);

However, even with the timeout 0, that may happen before onload fires (as far as targetFrame->loader()->documentLoader()->isLoadingInAPISense()) is concerned).

Moving those submits to in the onload handler (still with the setTimeout wrapper) seeems like a good idea.
Comment 1 Mihai Parparita 2010-08-13 18:05:28 PDT
Created attachment 64392 [details]
Comment 2 Dimitri Glazkov (Google) 2010-08-13 18:08:15 PDT
Comment on attachment 64392 [details]

Comment 3 WebKit Review Bot 2010-08-13 18:08:51 PDT
Attachment 64392 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dimitri Glazkov (Google) 2010-08-13 18:16:16 PDT
Comment on attachment 64392 [details]

style elf says no.
Comment 5 Mihai Parparita 2010-08-13 18:16:52 PDT
Created attachment 64394 [details]
Comment 6 Dimitri Glazkov (Google) 2010-08-13 18:23:38 PDT
Comment on attachment 64394 [details]

Comment 7 WebKit Commit Bot 2010-08-13 18:43:23 PDT
Comment on attachment 64392 [details]

Rejecting patch 64392 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 64392, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
Fetching: https://bugs.webkit.org/show_bug.cgi?id=43998&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 64392 from bug 43998.
NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 8 WebKit Commit Bot 2010-08-13 19:17:21 PDT
Comment on attachment 64394 [details]

Clearing flags on attachment: 64394

Committed r65348: <http://trac.webkit.org/changeset/65348>
Comment 9 WebKit Commit Bot 2010-08-13 19:17:26 PDT
All reviewed patches have been landed.  Closing bug.