Bug 43997 - add ability to test order-of-magnitude performance in layout tests
Summary: add ability to test order-of-magnitude performance in layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-13 16:48 PDT by Ojan Vafai
Modified: 2012-01-05 10:28 PST (History)
8 users (show)

See Also:


Attachments
Patch (19.08 KB, patch)
2010-08-13 16:56 PDT, Ojan Vafai
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-08-13 16:48:34 PDT
add ability to test order-of-magnitude in layout tests
Comment 1 Ojan Vafai 2010-08-13 16:56:01 PDT
Created attachment 64389 [details]
Patch
Comment 2 Dirk Pranke 2010-08-13 17:28:15 PDT
I'm glad these tests work they way they do, but the ChangeLog gives little insight into how or why you're doing these tests. Is it your intent to have the magnitude script be used by various perf tests to test expected performance? Should there be a page on webkit.org or something explaining this? 

Maybe at least a reference to magnitude-perf.js should be included into the ChangeLog?
Comment 3 Ojan Vafai 2010-08-13 17:32:40 PDT
(In reply to comment #2)
> Is it your intent to have the magnitude script be used by various perf tests to test expected performance?

Yes. There's precedent for this kind of testing with dump-as-markup.js.

> Should there be a page on webkit.org or something explaining this? 

Eventually yes. For now, I want to get it reviewed and into the code base and have a few people other than me write some tests to work out the kinks. Then I'll write something up and email webkit-dev.
Comment 4 Dirk Pranke 2010-08-13 17:34:43 PDT
groovy :)
Comment 5 Ojan Vafai 2010-08-18 10:35:03 PDT
Committed r65614: <http://trac.webkit.org/changeset/65614>
Comment 7 Tony Chang 2012-01-05 10:28:20 PST
Marked flaky in http://trac.webkit.org/changeset/104177 .