Bug 43990 - Add dictionary API type
Summary: Add dictionary API type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-13 13:57 PDT by Sam Weinig
Modified: 2010-08-13 14:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch (21.67 KB, patch)
2010-08-13 13:59 PDT, Sam Weinig 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-08-13 13:57:17 PDT 
Add dictionary API type.
Comment 1 Sam Weinig 2010-08-13 13:59:20 PDT 
Created attachment 64374 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-13 14:00:08 PDT 
Attachment 64374 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKDictionary.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:64:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:79:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WebKit2.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/Shared/ImmutableDictionary.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 5 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-08-13 14:33:51 PDT 
Landed in r65339.