RESOLVED FIXED Bug 43966
Web Inspector: rename InspectorValue::push and set to push{Value|Object|Array} and set{...}. 
https://bugs.webkit.org/show_bug.cgi?id=43966
Summary Web Inspector: rename InspectorValue::push and set to push{Value|Object|Array...
Pavel Feldman
Reported 2010-08-13 05:57:47 PDT
Patch to follow.
Attachments
[PATCH] Proposed change. (45.58 KB, patch)
2010-08-13 05:59 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Review comments addressed. (46.03 KB, patch)
2010-08-13 06:06 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed change. (46.02 KB, patch)
2010-08-13 06:16 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-08-13 05:59:39 PDT
Created attachment 64329 [details] [PATCH] Proposed change.
Ilya Tikhonovsky
Comment 2 2010-08-13 06:06:10 PDT
Comment on attachment 64329 [details] [PATCH] Proposed change. WebCore/inspector/CodeGeneratorInspector.pm:  + my $argumentType = $typeTransform{$type}->{$typeTransform{$typetype}->{"retVal"} ? "retVal" : "variable"}; Looks like retVal argument is not used any more. LGTM
Pavel Feldman
Comment 3 2010-08-13 06:06:25 PDT
Created attachment 64331 [details] [PATCH] Review comments addressed.
Eric Seidel (no email)
Comment 4 2010-08-13 06:13:06 PDT
Attachment 64329 [details] did not build on mac: Build output: http://queues.webkit.org/results/3759118
Ilya Tikhonovsky
Comment 5 2010-08-13 06:15:04 PDT
Comment on attachment 64331 [details] [PATCH] Review comments addressed. WebCore/inspector/InspectorValues.cpp:513 + bool InspectorValue::asObject(RefPtr<InspectorObject>* output) will not compile on MAC
Pavel Feldman
Comment 6 2010-08-13 06:16:44 PDT
Created attachment 64332 [details] [PATCH] Proposed change. Thanks for the hint, Ilya!
Eric Seidel (no email)
Comment 7 2010-08-13 06:22:07 PDT
Attachment 64331 [details] did not build on mac: Build output: http://queues.webkit.org/results/3706112
Pavel Feldman
Comment 8 2010-08-13 06:22:43 PDT
Comment on attachment 64332 [details] [PATCH] Proposed change. Clearing flags on attachment: 64332 Committed r65320: <http://trac.webkit.org/changeset/65320>
Pavel Feldman
Comment 9 2010-08-13 06:22:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.