Bug 43960 – [Chromium] styled scroll bar on the window is painted badly

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Hajime Morrita]

Scrollbars for the outermost frme are painted badly  when it has incomplete CSS style.
Precicely, 
- if it has CSS style that doesn't have  background-* properties, then
- The scrollbars are NOT painted, that causes visual artifact (old paint result lasts there.)

Note that Safari doesn't suffer from this problem because it doesn't allow to customize the outermost scrollbars.

Originally from http://code.google.com/p/chromium/issues/detail?id=47946.

[Hajime Morrita]

Created attachment 64317 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 64317 [details]
Patch

I am not sure if this is a good patch (not yet that knowledgeable about the mechanics here :), but here are a few nits:

WebCore/ChangeLog:15
 +          (WebCore::RenderObject::hasBackground):
Please use this template to outline the changes you made. For instance: "Moved most of this logic to blah".

WebCore/rendering/RenderScrollbar.cpp:144
 +  void RenderScrollbar::adjustStyle(RenderStyle* style) const
Why a separate method for this? It's only being used in one place and it's short enough to inline, I think?

WebCore/rendering/RenderScrollbar.cpp:149
 +      // causes visual artifact like non-repainted durty region.
"painted" and "dirty".

[Hajime Morrita]

Created attachment 64464 [details]
Patch

[Hajime Morrita]

Hi Dimitri, thank you for reviewing!
I updated the patch.

> WebCore/ChangeLog:15
>  +          (WebCore::RenderObject::hasBackground):
> Please use this template to outline the changes you made. For instance: "Moved most of this logic to blah".
OK, added some explanation. Thank you for pointing this out.

> 
> WebCore/rendering/RenderScrollbar.cpp:144
>  +  void RenderScrollbar::adjustStyle(RenderStyle* style) const
> Why a separate method for this? It's only being used in one place and it's short enough to inline, I think?
> 
Agreed and inlined.

> WebCore/rendering/RenderScrollbar.cpp:149
>  +      // causes visual artifact like non-repainted durty region.
> "painted" and "dirty".
Oops. Fixed.

[Kent Tamura]

Comment on attachment 64464 [details]
Patch

The patch looks reasonable.  I'll set r+ tomorrow if no one objects.

[Hajime Morrita]

Committed r66372: <http://trac.webkit.org/changeset/66372>