Bug 43957 - Need a LayoutTest to check that pages using Geolocation are not put in the page cache
Summary: Need a LayoutTest to check that pages using Geolocation are not put in the pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39879
  Show dependency treegraph
 
Reported: 2010-08-13 01:40 PDT by Steve Block
Modified: 2010-08-13 09:24 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.18 KB, patch)
2010-08-13 02:07 PDT, Steve Block
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-08-13 01:40:11 PDT
Currently, pages that use Geolocation are explicitly prevented from entering the page cache. This is planned to be fixed in Bug 43956 but until then, we should add a test to make sure that such pages do no enter the page cache.
Comment 1 Steve Block 2010-08-13 02:07:36 PDT
Created attachment 64314 [details]
Patch
Comment 2 Alexey Proskuryakov 2010-08-13 02:25:53 PDT
Comment on attachment 64314 [details]
Patch

As mentioned elsewhere, having a separate JS file is harmful in several ways. This is not grounds for r-, since many existing tests do the same, but I think that we should stop doing that, and maybe even convert existing tests.

+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

The HTML5 doctype is <!DOCTYPE html>, we should be using that for strict mode (if needed).
Comment 3 Steve Block 2010-08-13 08:57:16 PDT
> The HTML5 doctype is <!DOCTYPE html>, we should be using that for strict mode
> (if needed).

I don't think we need strict mode here. However, this DOCTYPE comes from TEMPLATE.html for the Geolocation tests. Looking at other TEMPLATE.html files, almost all specify a DOCTYPE [1] and of those, all but two [2] use this HTML2 DOCTYPE.

I could file a bug to change or remove the DOCTYPE for all Geolocation tests.

[1] No DOCTYPE ...
fast/dom/DeviceMotion/script-tests/TEMPLATE.html
fast/dom/DeviceOrientation/script-tests/TEMPLATE.html
storage/domstorage/events/script-tests/TEMPLATE.html
storage/domstorage/script-tests/TEMPLATE.html
storage/indexeddb/script-tests/TEMPLATE.html

[2] HTML5 DOCTYPE ...
platform/win/editing/selection/script-tests/TEMPLATE.html
platform/mac/editing/selection/script-tests/TEMPLATE.html
Comment 4 Steve Block 2010-08-13 09:24:07 PDT
Committed r65325: <http://trac.webkit.org/changeset/65325>