Bug 43943 - [V8] Support readonly Date attribute
Summary: [V8] Support readonly Date attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 42903
  Show dependency tree / graph
 
Reported: 2010-08-12 17:27 PDT by Kinuko Yasuda
Modified: 2010-09-01 23:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2010-08-12 18:43 PDT, Kinuko Yasuda 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-08-12 17:27:20 PDT 
Current CodeGeneratorV8 tries to create a hidden reference for a readonly Date attribute, but this makes compilation fail.
Date is represented as a double (or v8::Date) and is not a RefPtr type, so I think we shouldn't generate the hidden reference code for Date.
Comment 1 Kinuko Yasuda 2010-08-12 18:43:27 PDT 
Created attachment 64289 [details]
Patch
Comment 2 Kinuko Yasuda 2010-08-12 18:50:40 PDT 
I don't fully understand the code but I think it needs to go around the if statement around line 778 for Date (as we talked on chat).   Can you take a look at the patch?
Comment 3 Adam Barth 2010-08-31 20:03:25 PDT 
Seems related to jam magic.
Comment 4 Adam Barth 2010-08-31 20:04:13 PDT 
Sorry, John.  Turns out its not.
Comment 5 Adam Barth 2010-08-31 20:04:48 PDT 
Comment on attachment 64289 [details]
Patch

ok.
Comment 6 Kinuko Yasuda 2010-09-01 23:18:12 PDT 
Committed r66642: <http://trac.webkit.org/changeset/66642>