[Qt] ARMv5 Compiling error in FrameLoaderClientQt.cpp if QT_USE_FAST_OPERATOR_PLUS is defined globally

[Hui Huang]

Created attachment 64244 [details]
ARM compiler output

When building webkit trunk for S60 hardware using ARMv5 Compiler (RCVT 2.2 Build 686) with QT 4.7, the compiler reported the following error:
"X:\sf.plat\mw\qt\src\3rdparty\webkit\WebKit\qt\WebCoreSupport\FrameLoaderClientQt.cpp", line 1124: Error:  #135: class "QStringBuilder<char [19], QString>" has no member "toLocal8Bit"
                 (node) ? qPrintable(" originating from " + drtDescriptionSuitableForTestResult(node, 0)) : "");

The compiler output is attached as "ARM compiler output". 

The compiler uses the option -DQT_USE_FAST_OPERATOR_PLUS. According to http://doc.trolltech.com/4.7-snapshot/qstring.html, when QT_USE_FAST_OPERATOR_PLUS is defined globally, QString '+' operator is performed by internal template class QStringBuilder which does not have the member "toLocal8bit" which the qPrintable Macro uses.

[Hui Huang]

Created attachment 64245 [details]
Proposed patch

The attached proposed patch makes the compiler happy.

[Laszlo Gombos]

Comment on attachment 64245 [details]
Proposed patch

The ChangeLog should have had the [Qt] prefix as well, and perhaps some of the solution description should go to the ChnageLog and not to the bug, but otherwise the patch looks good to me, r+.

I will land the patch manually.

[Hui Huang]

Laszlo, thanks a lot for reviewing the patch. Thanks for the suggestions.

[Laszlo Gombos]

Comment on attachment 64245 [details]
Proposed patch

Committed as http://trac.webkit.org/changeset/65521.

[Hui Huang]

Laszlo, thanks again.