Bug 43923 - HTMLMediaElement::prepareForLoad should cancel current plug-in proxy media player
Summary: HTMLMediaElement::prepareForLoad should cancel current plug-in proxy media pl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media Elements (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks: 51249
  Show dependency treegraph
 
Reported: 2010-08-12 10:53 PDT by Eric Carlson
Modified: 2011-01-24 12:19 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (1.25 KB, patch)
2010-08-12 11:33 PDT, Eric Carlson
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2010-08-12 10:53:06 PDT
When building WebKit with PLUGIN_PROXY_FOR_VIDEO, the MediaPlayer is not destroyed and recreated when loading a new movie to avoid the expensive plug-in setup and handshake each time a movie is loaded. Because the current movie may still be loading, the plug-in proxy method cancelLoad should be called to give it a signal that a new movie will be loading.
Comment 1 Eric Carlson 2010-08-12 11:33:40 PDT
Created attachment 64242 [details]
proposed patch
Comment 2 David Kilzer (:ddkilzer) 2010-08-13 04:12:34 PDT
Comment on attachment 64242 [details]
proposed patch

r=me
Comment 3 Eric Carlson 2010-08-13 08:53:14 PDT
trac.webkit.org/changeset/65324
Comment 4 Ademar Reis 2011-01-24 12:19:13 PST
Revision r65324 cherry-picked into qtwebkit-2.2 with commit 6a0dc57 <http://gitorious.org/webkit/qtwebkit/commit/6a0dc57>