Bug 43909 – REGRESSION(r65181): It broke 35 layout tests fail on chromium-win (Requested by hamaji on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/65181 broke the build:
It broke 35 layout tests fail on chromium-win (Requested by hamaji on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 64212 [details]
ROLLOUT of r65181

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Shinichiro Hamaji]

Interestingly, it didn't fail on canary nor trybot, but the following URLs says this revision broke these tests.

http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/26011

http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/26012

[Shinichiro Hamaji]

Committed r65238: <http://trac.webkit.org/changeset/65238>

[WebKit Commit Bot]

Comment on attachment 64212 [details]
ROLLOUT of r65181

Rejecting patch 64212 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Parsed 3 diffs from patch file(s).
patching file WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file WebKit/chromium/public/WebFrameClient.h
Hunk #1 FAILED at 90.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebFrameClient.h.rej
patching file WebKit/chromium/src/FrameLoaderClientImpl.cpp
Hunk #1 FAILED at 248.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/FrameLoaderClientImpl.cpp.rej

Full output: http://queues.webkit.org/results/3709091

[Shinichiro Hamaji]

I've heard that this type of bot failures may be fixed by clobbering. I'll try re-reverting this patch when Chromium's WebKit revision is up-to-date. Unfortunately, non-PST WebKit roll has not been done yet, so I'll check this tomorrow again.

[Shinichiro Hamaji]

Re-landed in: http://trac.webkit.org/changeset/65604

It seems clobber build worked!

[Eric Seidel (no email)]

(In reply to comment #6)
> Re-landed in: http://trac.webkit.org/changeset/65604
> 
> It seems clobber build worked!

Does that mean we've filed a bug about the build system problem? :)

[Shinichiro Hamaji]

(In reply to comment #7)
> (In reply to comment #6)
> > Re-landed in: http://trac.webkit.org/changeset/65604
> > 
> > It seems clobber build worked!
> 
> Does that mean we've filed a bug about the build system problem? :)

Done :) http://code.google.com/p/chromium/issues/detail?id=52693