Bug 43907 - V8 code generator does not add V8BindingMacros.h include in all places it is needed
Summary: V8 code generator does not add V8BindingMacros.h include in all places it is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ben Murdoch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-12 05:00 PDT by Ben Murdoch
Modified: 2010-08-12 06:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch. (1.55 KB, patch)
2010-08-12 05:22 PDT, Ben Murdoch 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Murdoch 2010-08-12 05:00:18 PDT 
V8BindingMacros.h was added in http://trac.webkit.org/changeset/65005 and defines two macros: EXCEPTION_BLOCK and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK.

In the V8 CodeGenerator, we push this header when we generate code using EXCEPTION_BLOCK, but not STRING_TO_V8PARAMETER_EXCEPTION_BLOCK (see http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm#L1233 and http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm#L1240)

Patch to follow.
Comment 1 Dumitru Daniliuc 2010-08-12 05:04:46 PDT 
Thanks for catching this problem, and sorry I didn't notice it when changing that code...
Comment 2 Ben Murdoch 2010-08-12 05:22:34 PDT 
Created attachment 64211 [details]
Patch.
Comment 3 Ben Murdoch 2010-08-12 05:23:23 PDT 
(In reply to comment #1)
> Thanks for catching this problem, and sorry I didn't notice it when changing that code...

No problem!
Comment 4 Steve Block 2010-08-12 05:51:57 PDT 
Comment on attachment 64211 [details]
Patch.

r=me
Comment 5 WebKit Commit Bot 2010-08-12 06:28:18 PDT 
Comment on attachment 64211 [details]
Patch.

Clearing flags on attachment: 64211

Committed r65240: <http://trac.webkit.org/changeset/65240>
Comment 6 WebKit Commit Bot 2010-08-12 06:28:22 PDT 
All reviewed patches have been landed.  Closing bug.