Bug 43900 – Web Inspector: allow interrupting long running JS to execute inspector command

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Web Inspector: allow interrupting long running JS to execute inspector command

[Yury Semikhatsky]

Created attachment 64201 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 64201 [details]
Patch

WebKit/chromium/src/WebDevToolsAgentImpl.cpp:479
 +  bool WebDevToolsAgent::shouldInterruptForMessage(const WebString& message)
It would be better to move parsing part of the method to InspectorBackendDispatcher.

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 64201 [details])
> WebKit/chromium/src/WebDevToolsAgentImpl.cpp:479
>  +  bool WebDevToolsAgent::shouldInterruptForMessage(const WebString& message)
> It would be better to move parsing part of the method to InspectorBackendDispatcher.

Will do. Also I'm going to generate constant declarations for the commands on InspectorBackendDispatcher.h

[Pavel Feldman]

Comment on attachment 64201 [details]
Patch

Rename the web* methods please.

[Yury Semikhatsky]

Created attachment 64219 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 64219 [details]
Patch

WebCore/inspector/CodeGeneratorInspector.pm:312
 +      push(@function, "    const char* backendFunctionName = ${functionName}Cmd;");
it would be better to use ${functionName}Cmd directly

WebCore/inspector/CodeGeneratorInspector.pm:462
 +      if (array->length() < 1)
!array->length()

[WebKit Review Bot]

Attachment 64219 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3729090

[Yury Semikhatsky]

Created attachment 64223 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #6)
> (From update of attachment 64219 [details])
> WebCore/inspector/CodeGeneratorInspector.pm:312
>  +      push(@function, "    const char* backendFunctionName = ${functionName}Cmd;");
> it would be better to use ${functionName}Cmd directly
> 
Done.

> WebCore/inspector/CodeGeneratorInspector.pm:462
>  +      if (array->length() < 1)
> !array->length()
Done.

[WebKit Review Bot]

Attachment 64223 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3723084

[Pavel Feldman]

Comment on attachment 64223 [details]
Patch

This breaks chromium, other than that it is Ok.

[Pavel Feldman]

Comment on attachment 64223 [details]
Patch

r- for not compiling on chromium.

[Yury Semikhatsky]

(In reply to comment #12)
> (From update of attachment 64223 [details])
> r- for not compiling on chromium.
It successfully compiled on Chromium checkout on my linux box. It might be a bot issue.

[Pavel Feldman]

Comment on attachment 64223 [details]
Patch

r+ if you are saying it is a bot issue.

[Yury Semikhatsky]

Committed r65304