Bug 43897 - The JITStackFrame is wrong using Thumb-2 JIT with JSVALUE32_64
: The JITStackFrame is wrong using Thumb-2 JIT with JSVALUE32_64
Status: RESOLVED FIXED
: WebKit
JavaScriptCore
: 528+ (Nightly build)
: Other Linux
: P1 Blocker
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-08-12 00:37 PST by
Modified: 2010-08-18 03:28 PST (History)


Attachments
Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 (2.87 KB, patch)
2010-08-12 01:10 PST, Gabor Loki
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-08-12 00:37:06 PST
The asserts in JITThunks::JITThunks complain about the wrong offset values.
------- Comment #1 From 2010-08-12 01:10:46 PST -------
Created an attachment (id=64191) [details]
Fix the JITStackFrame in Thumb2 JIT with JSValue32_64

A 64 bits wide data is aligned to 8 bytes on ARM by default, but the ..._OFFSET macros in JITStubs.cpp are calculated as the args member is started from the fourth byte.
So, the macros are updated and the type of reserved member is replaced with JITStubArg, in order not to make any mistake about the offsets.
------- Comment #2 From 2010-08-13 01:01:33 PST -------
Hey Gabor, looks good but I'd like to test this patch doesn't break anything on darwin.  I'll test tomorrow morning & land assuming all is good.
------- Comment #3 From 2010-08-18 01:48:13 PST -------
(From update of attachment 64191 [details])
All good!
------- Comment #4 From 2010-08-18 03:03:37 PST -------
(From update of attachment 64191 [details])
Clearing flags on attachment: 64191

Committed r65596: <http://trac.webkit.org/changeset/65596>
------- Comment #5 From 2010-08-18 03:03:41 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #6 From 2010-08-18 03:28:22 PST -------
http://trac.webkit.org/changeset/65596 might have broken Qt Windows 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/65594
http://trac.webkit.org/changeset/65595
http://trac.webkit.org/changeset/65596
http://trac.webkit.org/changeset/65597