Bug 43893 – [Refactoring] TextEvent class has to many flags

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hajime Morrita]

From feedback on https://bugs.webkit.org/show_bug.cgi?id=43778

[Hajime Morrita]

Created attachment 64182 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 64182 [details]
Patch

> --- a/WebCore/dom/TextEvent.cpp
> +++ b/WebCore/dom/TextEvent.cpp
...
>  TextEvent::TextEvent(PassRefPtr<AbstractView> view, const String& data, PassRefPtr<DocumentFragment> pastingFragment,
> -                     bool isPaste, bool shouldSmartReplace, bool shouldMatchStyle)
> +                     TextEvent::InputType inputType, bool shouldSmartReplace, bool shouldMatchStyle)
>      : UIEvent(eventNames().textInputEvent, true, true, view, 0)
> +    , m_inputType(inputType)
>      , m_data(data)
> -    , m_isLineBreak(false)
> -    , m_isBackTab(false)
>      , m_pastingFragment(pastingFragment)
> -    , m_isPaste(isPaste)
>      , m_shouldSmartReplace(shouldSmartReplace)
>      , m_shouldMatchStyle(shouldMatchStyle)

This constructor looks too general to me. It might be better to have two constructors one for pasting and another for other input types.

[Hajime Morrita]

Created attachment 64207 [details]
Patch

[Hajime Morrita]

Hi Ryosuke, thank you for your quick review!
I updated the patch.

> This constructor looks too general to me. It might be better to have two constructors one for pasting and another for other input types.
Agreed and fixed to split the constructor into 2.

[Tony Chang]

Comment on attachment 64207 [details]
Patch

Great! Thanks for doing this.

[Hajime Morrita]

Committed r65287: <http://trac.webkit.org/changeset/65287>