Bug 43851 – [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Antonio Gomes]

If one launches the QtTestBrowser in QWebView (default) mode, and switch to GraphicsView based mode (Developer->GraphicsView->Toggle use of Graphics View), it does not initializate a QGraphicsWebView mode, but a QWebView again.

After that, all menus under Developer->GraphicsView gets activated but are *not* funcional, leading to crashes sometimes.

Patch coming ...

[Antonio Gomes]

Created attachment 64111 [details]
patch v1

All window options data (including the bool holding if the view is either QWebView or QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow. When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were getting broken.

Patch addresses this issue.

[Early Warning System Bot]

Attachment 64111 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3752047

[Antonio Gomes]

Created attachment 64113 [details]
(committed with r65160, r=hausmann) patch v2

Same as patch v1 (attachment 64111 [details]) but fixed the build bustage.

See comment #1 for summary.

[Simon Hausmann]

Comment on attachment 64113 [details]
(committed with r65160, r=hausmann) patch v2

r=me

[Antonio Gomes]

Comment on attachment 64113 [details]
(committed with r65160, r=hausmann) patch v2

Clearing flags on attachment: 64113

Committed r65160: <http://trac.webkit.org/changeset/r65160>

[Simon Hausmann]

Revision r65160 cherry-picked into qtwebkit-2.1 with commit b8bfbbe471d19ae0bb96ec1cdc63b4f0f1e08a42