Bug 43835 - [v8] Web Inspector: remove InjectDispatch.js
Summary: [v8] Web Inspector: remove InjectDispatch.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-11 01:07 PDT by Yury Semikhatsky
Modified: 2010-08-11 01:38 PDT (History)
13 users (show)

See Also:

Attachments
Patch (6.20 KB, patch)
2010-08-11 01:10 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-08-11 01:07:19 PDT 
Web Inspector: remove InjectDispatch.js now that all dispatching is done in generated native code.
Comment 1 Yury Semikhatsky 2010-08-11 01:10:12 PDT 
Created attachment 64085 [details]
Patch
Comment 2 Pavel Feldman 2010-08-11 01:17:47 PDT 
Comment on attachment 64085 [details]
Patch

WebKit/chromium/src/js/InjectDispatch.js: 
 +      DevToolsAgentHost.dispatch(call, method);
Should we remove this binding as well?
Comment 3 Yury Semikhatsky 2010-08-11 01:19:53 PDT 
(In reply to comment #2)
> (From update of attachment 64085 [details])
> WebKit/chromium/src/js/InjectDispatch.js: 
>  +      DevToolsAgentHost.dispatch(call, method);
> Should we remove this binding as well?

It's already been removed.
Comment 4 WebKit Review Bot 2010-08-11 01:31:28 PDT 
Attachment 64085 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3725050
Comment 5 Yury Semikhatsky 2010-08-11 01:33:16 PDT 
Comment on attachment 64085 [details]
Patch

Clearing flags on attachment: 64085

Committed r65136: <http://trac.webkit.org/changeset/65136>
Comment 6 Yury Semikhatsky 2010-08-11 01:33:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-08-11 01:38:17 PDT 
http://trac.webkit.org/changeset/65136 might have broken Chromium Linux Release