Bug 43802 – [GTK] WebBackForwardList's new_with_web_view should not be public

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gustavo Noronha (kov)]

Someone trying to use WebKitGTK+ through GObject Introspection bumped into a problem with WebBackForwardList - instantiating it using the default constructor fails badly because the WebKit object is not backed by an appropriate WebCore object. I think that is by design - the backforwardlist seems to only be useful when attached to a WebView anyway, and every WebView has its backforwardlist already. I think that means we want to do two things:

* Annotate WebBackForwardList as a type that should not allow instantiation - the WebView is the one who creates the only instances that should exist
* Deprecate webkit_web_back_forward_list_new_with_web_view as a publicly exported function, and make it private instead

Anyone knows better? I found no users of this API.

[Martin Robinson]

This sounds fine to me. What was the user trying to accomplish by the way? Perhaps our documentation isn't clear enough about whatever it was. I'd be willing to improve it here.

[Gustavo Noronha (kov)]

This has come second-hand to me, so I couldn't find out what the user was trying to accomplish - he asked Tomeu (who works in introspection) for help, and Tomeu told me about it. Looks like the person who got confused with this is 'lucian', and hangs out on IRC, so it should be possible for us to ask him =)

[Gustavo Noronha (kov)]

Created attachment 64731 [details]
deprecate the function

[Martin Robinson]

Comment on attachment 64731 [details]
deprecate the function

LGTM!

[Gustavo Noronha (kov)]

Landed as r65615.