WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43802
[GTK] WebBackForwardList's new_with_web_view should not be public
https://bugs.webkit.org/show_bug.cgi?id=43802
Summary
[GTK] WebBackForwardList's new_with_web_view should not be public
Gustavo Noronha (kov)
Reported
2010-08-10 11:50:44 PDT
Someone trying to use WebKitGTK+ through GObject Introspection bumped into a problem with WebBackForwardList - instantiating it using the default constructor fails badly because the WebKit object is not backed by an appropriate WebCore object. I think that is by design - the backforwardlist seems to only be useful when attached to a WebView anyway, and every WebView has its backforwardlist already. I think that means we want to do two things: * Annotate WebBackForwardList as a type that should not allow instantiation - the WebView is the one who creates the only instances that should exist * Deprecate webkit_web_back_forward_list_new_with_web_view as a publicly exported function, and make it private instead Anyone knows better? I found no users of this API.
Attachments
deprecate the function
(1.74 KB, patch)
2010-08-18 10:31 PDT
,
Gustavo Noronha (kov)
mrobinson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Robinson
Comment 1
2010-08-10 14:05:31 PDT
This sounds fine to me. What was the user trying to accomplish by the way? Perhaps our documentation isn't clear enough about whatever it was. I'd be willing to improve it here.
Gustavo Noronha (kov)
Comment 2
2010-08-10 16:39:07 PDT
This has come second-hand to me, so I couldn't find out what the user was trying to accomplish - he asked Tomeu (who works in introspection) for help, and Tomeu told me about it. Looks like the person who got confused with this is 'lucian', and hangs out on IRC, so it should be possible for us to ask him =)
Gustavo Noronha (kov)
Comment 3
2010-08-18 10:31:21 PDT
Created
attachment 64731
[details]
deprecate the function
Martin Robinson
Comment 4
2010-08-18 10:38:14 PDT
Comment on
attachment 64731
[details]
deprecate the function LGTM!
Gustavo Noronha (kov)
Comment 5
2010-08-18 10:47:43 PDT
Landed as
r65615
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug