Bug 43802 - [GTK] WebBackForwardList's new_with_web_view should not be public
Summary: [GTK] WebBackForwardList's new_with_web_view should not be public
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2010-08-10 11:50 PDT by Gustavo Noronha (kov)
Modified: 2010-08-18 10:47 PDT (History)
2 users (show)

See Also:

deprecate the function (1.74 KB, patch)
2010-08-18 10:31 PDT, Gustavo Noronha (kov)
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-08-10 11:50:44 PDT
Someone trying to use WebKitGTK+ through GObject Introspection bumped into a problem with WebBackForwardList - instantiating it using the default constructor fails badly because the WebKit object is not backed by an appropriate WebCore object. I think that is by design - the backforwardlist seems to only be useful when attached to a WebView anyway, and every WebView has its backforwardlist already. I think that means we want to do two things:

* Annotate WebBackForwardList as a type that should not allow instantiation - the WebView is the one who creates the only instances that should exist
* Deprecate webkit_web_back_forward_list_new_with_web_view as a publicly exported function, and make it private instead

Anyone knows better? I found no users of this API.
Comment 1 Martin Robinson 2010-08-10 14:05:31 PDT
This sounds fine to me. What was the user trying to accomplish by the way? Perhaps our documentation isn't clear enough about whatever it was. I'd be willing to improve it here.
Comment 2 Gustavo Noronha (kov) 2010-08-10 16:39:07 PDT
This has come second-hand to me, so I couldn't find out what the user was trying to accomplish - he asked Tomeu (who works in introspection) for help, and Tomeu told me about it. Looks like the person who got confused with this is 'lucian', and hangs out on IRC, so it should be possible for us to ask him =)
Comment 3 Gustavo Noronha (kov) 2010-08-18 10:31:21 PDT
Created attachment 64731 [details]
deprecate the function
Comment 4 Martin Robinson 2010-08-18 10:38:14 PDT
Comment on attachment 64731 [details]
deprecate the function

Comment 5 Gustavo Noronha (kov) 2010-08-18 10:47:43 PDT
Landed as r65615.