Bug 43797 - Navigating to a plug-in document fails if plug-ins are disabled
Summary: Navigating to a plug-in document fails if plug-ins are disabled
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 43117
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-10 10:23 PDT by Bernhard Bauer
Modified: 2022-07-01 11:35 PDT (History)
5 users (show)

See Also:


Attachments
Return plugin data if plugins are disabled. (2.77 KB, patch)
2010-08-10 10:25 PDT, Bernhard Bauer
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Bauer 2010-08-10 10:23:28 PDT
Steps to reproduce: 
* Disable plug-ins
* Go to a URL that's displayed by a plug-in (e.g. a PDF or SWF file)

In Safari, you get the rather unhelpful error message 'Safari can’t open <URL> because Mac OS X doesn’t recognize Internet addresses starting with “http:”.', Chrome just silently fails (or crashes if the navigation happens to open a new tab, but that's another bug).

The navigation fails because Page::pluginData returns 0 if plug-ins are disabled, so the checks to see if a plug-in can handle the document fail. I think we should simply return the pluginData object here. There are additional checks later on to make sure the plug-in is not actually loaded, and I added checks in DOMPluginArray and DOMMimeTypeArray to return empty lists there.

For Chrome, the result is that you get an empty page and the plug-in blocked indicator, which is more helpful than silently failing. I couldn't check the result for Safari.

This is also a bit more consistent with the behavior in SubFrameLoader::shouldUsePlugin, which returns true if plug-ins are disabled, so that we try to load the plug-in and fail, notifying the FrameLoaderClient about it.
Comment 1 Bernhard Bauer 2010-08-10 10:25:38 PDT
Created attachment 64024 [details]
Return plugin data if plugins are disabled.
Comment 2 Eric Seidel (no email) 2010-08-12 07:19:53 PDT
Comment on attachment 64024 [details]
Return plugin data if plugins are disabled.

This needs a layout test, or explanation (in the ChangeLog) of why such a test is impossible.
Comment 3 Alexey Proskuryakov 2022-07-01 11:35:15 PDT
Mass closing plug-in bugs, as plug-in support has been removed from WebKit.

Please comment and/or reopen if this still affects WebKit in some way.