Bug 43793 – Date("") should be an invalid date time

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Leo Yang]

Date("") should be an invalid date time. isNaN(new Date("")) should return true.

[Leo Yang]

Created attachment 64013 [details]
Patch

[Geoffrey Garen]

Comment on attachment 64013 [details]
Patch

Why should new Date("") be NaN? Can you point to a part of a spec, or the behavior of another browser? As a general rule, it's better for your ChangeLog to explain the why, rather than the what.

>      cachedDateString = UString();
> +    cachedDateStringValue = NaN;

Can you explain why you needed to make this change?

UString() should not be == to UString(""). If it is, I think we have another bug to solve.

[Leo Yang]

(In reply to comment #2)
> (From update of attachment 64013 [details])
> Why should new Date("") be NaN? Can you point to a part of a spec, or the behavior of another browser? As a general rule, it's better for your ChangeLog to explain the why, rather than the what.
For IE and FireFox, new Date("") is NaN.

> 
> >      cachedDateString = UString();
> > +    cachedDateStringValue = NaN;
> 
> Can you explain why you needed to make this change?
There isn't initial value for cachedDateStringValue. Do we depend on the first assignment when Date cache is hit? After we call restDateCache(), we leave cachedDateStringValue and reset cachedDateString, it's not consistent.

> 
> UString() should not be == to UString(""). If it is, I think we have another bug to solve.
Yes, I don't know why UString() == UString(""). This also need to be fixed.

[Leo Yang]

Created attachment 64112 [details]
Patch - fix commit message and comments

[Geoffrey Garen]

Comment on attachment 64112 [details]
Patch - fix commit message and comments

r=me

[WebKit Commit Bot]

Comment on attachment 64112 [details]
Patch - fix commit message and comments

Clearing flags on attachment: 64112

Committed r65201: <http://trac.webkit.org/changeset/65201>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.