Bug 43790 - [EFL] Add video files to enable video in WebKit EFL
Summary: [EFL] Add video files to enable video in WebKit EFL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 44098
  Show dependency tree / graph
 
Reported: 2010-08-10 06:58 PDT by Gyuyoung Kim
Modified: 2010-08-24 03:07 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2010-08-10 07:05 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
patch (3.23 KB, patch)
2010-08-10 07:08 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2010-08-10 06:58:57 PDT 
WebKit EFL doesn't support to enable video yet. This patch just can enable video without build breaks. HTML5's video is not run in WebKit EFL yet. I will contribute more patches in order to run html5video.

Thanks.
Comment 1 Gyuyoung Kim 2010-08-10 07:05:27 PDT 
Created attachment 64009 [details]
Patch
Comment 2 Gyuyoung Kim 2010-08-10 07:08:16 PDT 
Created attachment 64010 [details]
patch

There was coding style error. I fix it.
Comment 3 Antonio Gomes 2010-08-10 07:24:39 PDT 
Comment on attachment 64010 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2010-08-10 08:09:15 PDT 
Comment on attachment 64010 [details]
patch

Rejecting patch 64010 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Last 500 characters of output:
CommitQueue/LayoutTests
Testing 20806 test cases.
media/video-volume.html -> timed out
Sampling process 87309 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 87309 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 17218 tests run.
697.74s total testing time

17217 test cases (99%) succeeded
1 test case (<1%) timed out
33 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3765018
Comment 5 Gyuyoung Kim 2010-08-10 19:15:13 PDT 
Hello eric,

I don't know why layout test is failed by this patch. This patch doesn't enable VIDEO in WebKit EFL. Just add files regarding html5 video.

You know, WebKit EFL doesn't have DRT yet. (But, Our engineer will contribute DRT soon.) I run the media/video-volume.html on EWebLauncher directly. There is no time-out. 

Could you let me know how to solve this problem ?

Thanks.
Comment 6 Eric Seidel (no email) 2010-08-10 19:25:52 PDT 
Comment on attachment 64010 [details]
patch

There seems to be some sort of problem on the bot.
Comment 7 Eric Seidel (no email) 2010-08-10 19:26:47 PDT 
This is the old "all media tests hang or crash" bug that we saw long ago.  Which iirc was a CoreVideo bug which was fixed in a later version of quicktime.

I'll look at the commit-bot this evening, but I believe it's a completely up-to-date leopard install.
Comment 8 WebKit Commit Bot 2010-08-10 19:53:31 PDT 
Comment on attachment 64010 [details]
patch

Clearing flags on attachment: 64010

Committed r65117: <http://trac.webkit.org/changeset/65117>
Comment 9 WebKit Commit Bot 2010-08-10 19:53:37 PDT 
All reviewed patches have been landed.  Closing bug.