RESOLVED FIXED Bug 43790
[EFL] Add video files to enable video in WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=43790
Summary [EFL] Add video files to enable video in WebKit EFL
Gyuyoung Kim
Reported 2010-08-10 06:58:57 PDT
WebKit EFL doesn't support to enable video yet. This patch just can enable video without build breaks. HTML5's video is not run in WebKit EFL yet. I will contribute more patches in order to run html5video. Thanks.
Attachments
Patch (3.24 KB, patch)
2010-08-10 07:05 PDT, Gyuyoung Kim
no flags
patch (3.23 KB, patch)
2010-08-10 07:08 PDT, Gyuyoung Kim
no flags
Gyuyoung Kim
Comment 1 2010-08-10 07:05:27 PDT
Gyuyoung Kim
Comment 2 2010-08-10 07:08:16 PDT
Created attachment 64010 [details] patch There was coding style error. I fix it.
Antonio Gomes
Comment 3 2010-08-10 07:24:39 PDT
Comment on attachment 64010 [details] patch r=me
WebKit Commit Bot
Comment 4 2010-08-10 08:09:15 PDT
Comment on attachment 64010 [details] patch Rejecting patch 64010 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: CommitQueue/LayoutTests Testing 20806 test cases. media/video-volume.html -> timed out Sampling process 87309 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 87309 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 17218 tests run. 697.74s total testing time 17217 test cases (99%) succeeded 1 test case (<1%) timed out 33 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3765018
Gyuyoung Kim
Comment 5 2010-08-10 19:15:13 PDT
Hello eric, I don't know why layout test is failed by this patch. This patch doesn't enable VIDEO in WebKit EFL. Just add files regarding html5 video. You know, WebKit EFL doesn't have DRT yet. (But, Our engineer will contribute DRT soon.) I run the media/video-volume.html on EWebLauncher directly. There is no time-out. Could you let me know how to solve this problem ? Thanks.
Eric Seidel (no email)
Comment 6 2010-08-10 19:25:52 PDT
Comment on attachment 64010 [details] patch There seems to be some sort of problem on the bot.
Eric Seidel (no email)
Comment 7 2010-08-10 19:26:47 PDT
This is the old "all media tests hang or crash" bug that we saw long ago. Which iirc was a CoreVideo bug which was fixed in a later version of quicktime. I'll look at the commit-bot this evening, but I believe it's a completely up-to-date leopard install.
WebKit Commit Bot
Comment 8 2010-08-10 19:53:31 PDT
Comment on attachment 64010 [details] patch Clearing flags on attachment: 64010 Committed r65117: <http://trac.webkit.org/changeset/65117>
WebKit Commit Bot
Comment 9 2010-08-10 19:53:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.