WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43788
Web Inspector: move databse processing to native layer.
https://bugs.webkit.org/show_bug.cgi?id=43788
Summary
Web Inspector: move databse processing to native layer.
Pavel Feldman
Reported
2010-08-10 06:07:03 PDT
Rationale: - Slowly move out everything from InjectedScript - Databases from iframes can now be processed - Removed async dispatching on InjectedScript and its support from generator.
Attachments
[PATCH] Proposed change. Will add to XCode proj on landing.
(41.56 KB, patch)
2010-08-10 06:14 PDT
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2010-08-10 06:14:07 PDT
Created
attachment 64007
[details]
[PATCH] Proposed change. Will add to XCode proj on landing.
Yury Semikhatsky
Comment 2
2010-08-10 06:45:50 PDT
Comment on
attachment 64007
[details]
[PATCH] Proposed change. Will add to XCode proj on landing. WebCore/inspector/InspectorBackend.cpp:139 + *transactionId = m_inspectorController->m_storageAgent->executeSQL(database, query); Please introduce a getter for storage agent as we do for other agents. WebCore/inspector/InspectorStorageAgent.h:34 + #include "wtf/PassOwnPtr.h" should be <wtf/PassRefPtr.h> ? WebCore/inspector/InspectorStorageAgent.cpp:49 + #include "wtf/Vector.h" <wtf/Vector.h> WebCore/inspector/InspectorStorageAgent.cpp:39 + #include "SQLValue.h" wrong include order
Pavel Feldman
Comment 3
2010-08-10 09:07:07 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... C WebCore/inspector/front-end/Database.js => WebCore/inspector/InspectorStorageAgent.h M WebCore/CMakeLists.txt M WebCore/ChangeLog M WebCore/GNUmakefile.am M WebCore/WebCore.gypi M WebCore/WebCore.pro M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/bindings/js/JSInjectedScriptHostCustom.cpp M WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp M WebCore/inspector/CodeGeneratorInspector.pm M WebCore/inspector/InjectedScript.cpp M WebCore/inspector/InjectedScript.h M WebCore/inspector/InjectedScriptHost.cpp M WebCore/inspector/InjectedScriptHost.h M WebCore/inspector/InjectedScriptHost.idl M WebCore/inspector/Inspector.idl M WebCore/inspector/InspectorBackend.cpp M WebCore/inspector/InspectorBackend.h M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h A WebCore/inspector/InspectorStorageAgent.cpp M WebCore/inspector/front-end/Database.js M WebCore/inspector/front-end/DatabaseQueryView.js M WebCore/inspector/front-end/DatabaseTableView.js M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/InjectedScriptAccess.js M WebCore/inspector/front-end/StoragePanel.js Committed
r65072
WebKit Review Bot
Comment 4
2010-08-10 09:14:22 PDT
http://trac.webkit.org/changeset/65072
might have broken Qt Linux Release minimal The following changes are on the blame list:
http://trac.webkit.org/changeset/65072
http://trac.webkit.org/changeset/65069
http://trac.webkit.org/changeset/65070
http://trac.webkit.org/changeset/65071
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug