Bug 43785 - [V8] DeviceMotionEvent can not be used from JavaScript
Summary: [V8] DeviceMotionEvent can not be used from JavaScript
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30335
  Show dependency treegraph
 
Reported: 2010-08-10 05:13 PDT by Steve Block
Modified: 2010-08-10 09:14 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2010-08-10 05:21 PDT, Steve Block
jorlow: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-08-10 05:13:12 PDT
This causes fast/dom/DeviceMotion/create-event.html and fast/dom/DeviceMotion/optional-event-properties.html to fail with V8.

The cause is that DeviceMotionEvent is not handled in toV8(Event*). This was omitted when the DeviceMotionEvent event was added in Bug 42865
Comment 1 Steve Block 2010-08-10 05:21:44 PDT
Created attachment 64000 [details]
Patch
Comment 2 Jeremy Orlow 2010-08-10 05:57:33 PDT
Comment on attachment 64000 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2010-08-10 06:51:20 PDT
Comment on attachment 64000 [details]
Patch

Rejecting patch 64000 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Last 500 characters of output:
CommitQueue/LayoutTests
Testing 20806 test cases.
media/video-volume.html -> timed out
Sampling process 65677 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 65677 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 17218 tests run.
807.59s total testing time

17217 test cases (99%) succeeded
1 test case (<1%) timed out
34 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3770028
Comment 4 Steve Block 2010-08-10 07:15:19 PDT
Committed r65071: <http://trac.webkit.org/changeset/65071>
Comment 5 WebKit Review Bot 2010-08-10 09:14:45 PDT
http://trac.webkit.org/changeset/65071 might have broken Qt Linux Release minimal
The following changes are on the blame list:
http://trac.webkit.org/changeset/65072
http://trac.webkit.org/changeset/65069
http://trac.webkit.org/changeset/65070
http://trac.webkit.org/changeset/65071