Bug 43784 - Make CSSSelector::specificity() non-recursive.
Summary: Make CSSSelector::specificity() non-recursive.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 42806
  Show dependency tree / graph
 
Reported: 2010-08-10 04:55 PDT by Hayato Ito
Modified: 2010-08-10 22:21 PDT (History)
1 user (show)

See Also:

Attachments
make-it-iterative (4.04 KB, patch)
2010-08-10 05:23 PDT, Hayato Ito 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2010-08-10 04:55:23 PDT 
Please see the master bug for details.
https://bugs.webkit.org/show_bug.cgi?id=42806

We have to make CSSSelector::specificity() non-recursive in order to avoid stack overflow when a long CSS selector is used.
Comment 1 Hayato Ito 2010-08-10 05:23:00 PDT 
Created attachment 64001 [details]
make-it-iterative
Comment 2 Kent Tamura 2010-08-10 22:02:30 PDT 
Comment on attachment 64001 [details]
make-it-iterative

Looks good.
Comment 3 WebKit Commit Bot 2010-08-10 22:21:19 PDT 
Comment on attachment 64001 [details]
make-it-iterative

Clearing flags on attachment: 64001

Committed r65123: <http://trac.webkit.org/changeset/65123>
Comment 4 WebKit Commit Bot 2010-08-10 22:21:23 PDT 
All reviewed patches have been landed.  Closing bug.