Bug 43773 - REGRESSION(r65056): "Clearly I missed something. I'm too tired to try and fix now. Will re-land in the morning." (Requested by eseidel on #webkit).
Summary: REGRESSION(r65056): "Clearly I missed something. I'm too tired to try and fi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 43762
  Show dependency tree / graph
 
Reported: 2010-08-10 01:12 PDT by WebKit Review Bot
Modified: 2010-08-10 10:02 PDT (History)
4 users (show)

See Also:

Attachments
ROLLOUT of r65056 (6.70 KB, patch)
2010-08-10 01:12 PDT, WebKit Review Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-08-10 01:12:14 PDT 
http://trac.webkit.org/changeset/65056 broke the build:
"Clearly I missed something.  I'm too tired to try and fix now.  Will re-land in the morning." (Requested by eseidel on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-08-10 01:12:24 PDT 
Created attachment 63984 [details]
ROLLOUT of r65056

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2010-08-10 01:39:32 PDT 
Comment on attachment 63984 [details]
ROLLOUT of r65056

Rejecting patch 63984 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Last 500 characters of output:
1 succeeded at 1 with fuzz 3.
patching file WebCore/html/HTMLConstructionSite.cpp
Hunk #1 FAILED at 93.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLConstructionSite.cpp.rej
patching file WebCore/html/HTMLElement.cpp
Hunk #1 FAILED at 549.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLElement.cpp.rej
patching file WebCore/html/HTMLTreeBuilder.cpp
Hunk #1 FAILED at 1997.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLTreeBuilder.cpp.rej

Full output: http://queues.webkit.org/results/3713022
Comment 3 Csaba Osztrogonác 2010-08-10 03:49:44 PDT 
Comment on attachment 63984 [details]
ROLLOUT of r65056

Clearing flags on attachment: 63984

Committed r65064: <http://trac.webkit.org/changeset/65064>
Comment 4 Csaba Osztrogonác 2010-08-10 03:49:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2010-08-10 03:56:27 PDT 
(In reply to comment #2)
> (From update of attachment 63984 [details])
> Rejecting patch 63984 from commit-queue.

It seems cq is sick a little bit.
Comment 6 Eric Seidel (no email) 2010-08-10 10:02:06 PDT 
It was sick, yes. :(  I believe I've fixed it now though.