Bug 43769 - Test results server does not merge correctly for tests not in incremental json
Summary: Test results server does not merge correctly for tests not in incremental json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Victor Wang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 21:49 PDT by Victor Wang
Modified: 2010-08-10 11:41 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (4.08 KB, patch)
2010-08-09 22:03 PDT, Victor Wang 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Wang 2010-08-09 21:49:34 PDT 
The current test results server iterates through tests in incremental json and merges them into existing aggregated results. For tests that are in aggregated json but not in incremental json, their results and times also need to update.
Comment 1 Victor Wang 2010-08-09 22:03:52 PDT 
Created attachment 63975 [details]
Proposed Patch
Comment 2 Ojan Vafai 2010-08-10 10:44:58 PDT 
Comment on attachment 63975 [details]
Proposed Patch

We'll need to clobber all the results on test_results.appspot.com before we switch over to them I guess?
Comment 3 Victor Wang 2010-08-10 11:02:58 PDT 
(In reply to comment #2)
> (From update of attachment 63975 [details])
> We'll need to clobber all the results on test_results.appspot.com before we switch over to them I guess?
yes.
Comment 4 Victor Wang 2010-08-10 11:41:01 PDT 
Committed r65080: <http://trac.webkit.org/changeset/65080>