Clients of HTMLTokenizer should be able to see where characters when in the token
Created attachment 63969 [details] Patch
This facility will be used to implement view-source in Bug 43746.
Attachment 63969 [details] did not build on qt: Build output: http://queues.webkit.org/results/3705014
Attachment 63969 [details] did not build on mac: Build output: http://queues.webkit.org/results/3772008
Attachment 63969 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3728008
Comment on attachment 63969 [details] Patch I worry there is an off-by-one typo waiting to happen here. Looks OK AFAICT. Did you test perf?
Comment on attachment 63969 [details] Patch > Did you test perf? I did. It showed a minor slowdown (~1%) on the parser benchmark. We discussed in person whether we should worry about these things. I'm inclined to land this now (to unblock the view-source + removing the old parser work), but I'll play with it a bit to understand the performance sensitivity. I suspect it comes from adding 4 ints to the HTMLToken::Attribute structure, but we'll find out.
Comment on attachment 63969 [details] Patch Clearing flags on attachment: 63969 Committed r65110: <http://trac.webkit.org/changeset/65110>
All reviewed patches have been landed. Closing bug.