Bug 43755 – fast/dom/Window/window-properties.html is pretty slow

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mihai Parparita]

It takes 5.9 seconds to run on my Mac Pro, it looks like there's some pretty easy performance tweaks.

Geoff, I'm cc-ing you since I'm hoping you can review this, since you're the original author of this (incarnation of this) test.

[Mihai Parparita]

Created attachment 63947 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 63947 [details]
Patch

Rejecting patch 63947 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20806 test cases.
http/tests/misc/image-blocked-src-change.html -> failed

Exiting early after 1 failures. 20032 tests run.
673.67s total testing time

20031 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
88 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3756008

[Mihai Parparita]

Comment on attachment 63947 [details]
Patch

I see no reason why this should have made  http/tests/misc/image-blocked-src-change.html fail, and per bug 33153 and bug 37557 it may be a flaky test, so I'd like the commit queue to try again.

[WebKit Commit Bot]

Comment on attachment 63947 [details]
Patch

Rejecting patch 63947 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.

[Ryosuke Niwa]

Comment on attachment 63947 [details]
Patch

Adding back to the commit queue since the failure seems to be caused by a flaky test.

[WebKit Commit Bot]

Comment on attachment 63947 [details]
Patch

Rejecting patch 63947 from commit-queue.

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
fatal: Unable to create '/Users/eseidel/Projects/CommitQueue/.git/svn/refs/remotes/trunk/index.lock': File exists.

If no other git process is currently running, this probably means a
git process crashed in this repository earlier. Make sure no other git
process is running and remove the file manually to continue.
write-tree: command returned error: 128

Died at WebKitTools/Scripts/update-webkit line 129.

Full output: http://queues.webkit.org/results/3755007

[WebKit Commit Bot]

Comment on attachment 63947 [details]
Patch

Rejecting patch 63947 from commit-queue.

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
fatal: Unable to create '/Users/eseidel/Projects/CommitQueue/.git/svn/refs/remotes/trunk/index.lock': File exists.

If no other git process is currently running, this probably means a
git process crashed in this repository earlier. Make sure no other git
process is running and remove the file manually to continue.
write-tree: command returned error: 128

Died at WebKitTools/Scripts/update-webkit line 129.

Full output: http://queues.webkit.org/results/3709012

[WebKit Commit Bot]

Comment on attachment 63947 [details]
Patch

Rejecting patch 63947 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20822 test cases.
media/video-aspect-ratio.html -> crashed

Exiting early after 1 failures. 17166 tests run.
683.55s total testing time

17165 test cases (99%) succeeded
1 test case (<1%) crashed
34 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3756046

[James Robinson]

Comment on attachment 63947 [details]
Patch

Test flaked

[WebKit Commit Bot]

Comment on attachment 63947 [details]
Patch

Rejecting patch 63947 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Last 500 characters of output:
mmitQueue/LayoutTests
Testing 20822 test cases.
media/video-autoplay.html -> timed out
Sampling process 28075 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 28075 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 17167 tests run.
664.86s total testing time

17166 test cases (99%) succeeded
1 test case (<1%) timed out
35 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3727028

[Mihai Parparita]

*sigh* Another seemingly irrelevant test failure. Per http://test-results.appspot.com/dashboards/flakiness_dashboard.html#maxResults=750&tests=media%2Fvideo-autoplay.html it may be flaky.

James Robinson said he'll land this for me.

[James Robinson]

Comment on attachment 63947 [details]
Patch

Clearing flags on attachment: 63947

Committed r65109: <http://trac.webkit.org/changeset/65109>

[James Robinson]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

I think we must be hitting the CoreVideo random crasher again?  Except I thought that was fixed?  The leopard box running the commit-queue is up to date as far as I know.  Maybe it has (or needs) a hacked CoreVideo version again?