Bug 43753 - [chromium] Geolocation breaks the compile if ENABLE_GEOLOCATION is set to 0
Summary: [chromium] Geolocation breaks the compile if ENABLE_GEOLOCATION is set to 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 15:45 PDT by James Robinson
Modified: 2010-08-11 16:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2010-08-11 07:19 PDT, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-08-09 15:45:43 PDT 
If the feature is off the build should still work.  Instead there are compile errors:

WebCore/bindings/v8/custom/V8CustomPositionCallback.cpp:68: error: no matching function for call to ‘toV8(WebCore::Geoposition*&)’
out/Release/obj/gen/webkit/bindings/V8Event.h:49: note: candidates are: v8::Handle<v8::Value> WebCore::toV8(WebCore::Event*)
out/Release/obj/gen/webkit/bindings/V8Event.h:50: note:                 v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::Event>)
out/Release/obj/gen/webkit/bindings/V8XPathNSResolver.h:47: note:                 v8::Handle<v8::Value> WebCore::toV8(WebCore::XPathNSResolver*)
out/Release/obj/gen/webkit/bindings/V8XPathNSResolver.h:48: note:                 v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::XPathNSResolver>)
WebCore/bindings/v8/custom/V8CustomPositionErrorCallback.cpp: In member function ‘virtual void WebCore::V8CustomPositionErrorCallback::handleEvent(WebCore::PositionError*)’:
WebCore/bindings/v8/custom/V8CustomPositionErrorCallback.cpp:68: error: no matching function for call to ‘toV8(WebCore::PositionError*&)’
out/Release/obj/gen/webkit/bindings/V8Event.h:49: note: candidates are: v8::Handle<v8::Value> WebCore::toV8(WebCore::Event*)
out/Release/obj/gen/webkit/bindings/V8Event.h:50: note:                 v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::Event>)
out/Release/obj/gen/webkit/bindings/V8XPathNSResolver.h:47: note:                 v8::Handle<v8::Value> WebCore::toV8(WebCore::XPathNSResolver*)
out/Release/obj/gen/webkit/bindings/V8XPathNSResolver.h:48: note:                 v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::XPathNSResolver>)
make: *** [out/Release/obj.target/webcore/WebCore/bindings/v8/custom/V8CustomPositionCallback.o] Error 1
Comment 1 jochen 2010-08-09 23:43:42 PDT 
yeah, looks like all of these should be protected by #if ENABLE(GEOLOCATION) ... #endif
Comment 2 Steve Block 2010-08-11 07:19:30 PDT 
Created attachment 64110 [details]
Patch
Comment 3 WebKit Commit Bot 2010-08-11 16:47:03 PDT 
Comment on attachment 64110 [details]
Patch

Clearing flags on attachment: 64110

Committed r65199: <http://trac.webkit.org/changeset/65199>
Comment 4 WebKit Commit Bot 2010-08-11 16:47:08 PDT 
All reviewed patches have been landed.  Closing bug.