Bug 43748 - [chromium] Blue line visible at the right hand side of the window with accelerated compositor
Summary: [chromium] Blue line visible at the right hand side of the window with accele...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 14:55 PDT by Nat Duca
Modified: 2010-08-09 17:45 PDT (History)
6 users (show)

See Also:


Attachments
Proposed fix (3.15 KB, patch)
2010-08-09 15:01 PDT, Nat Duca
dglazkov: review-
Details | Formatted Diff | Diff
Trying again, this time with no tabs :) (3.15 KB, patch)
2010-08-09 15:30 PDT, Nat Duca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2010-08-09 14:55:06 PDT
When running chrome with --enable-accelerated-compositing, evenly-sized windows will have a 1px wide blue line on the right or bottom of the screen, to the right of the scroll bar.
Comment 1 Nat Duca 2010-08-09 15:01:10 PDT
Created attachment 63932 [details]
Proposed fix

Proposed fix.
Comment 2 WebKit Review Bot 2010-08-09 15:05:26 PDT
Attachment 63932 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dimitri Glazkov (Google) 2010-08-09 15:17:52 PDT
Comment on attachment 63932 [details]
Proposed fix

Style elf says no. But the patch looks reasonable. Can haz no tabs in patch?
Comment 4 Nat Duca 2010-08-09 15:30:04 PDT
Created attachment 63940 [details]
Trying again, this time with no tabs :)
Comment 5 Dimitri Glazkov (Google) 2010-08-09 15:40:31 PDT
Comment on attachment 63940 [details]
Trying again, this time with no tabs :)

ok. Don't forget to mark "commit-queue?" if you want the magic bot to land it for you.
Comment 6 Nat Duca 2010-08-09 15:45:23 PDT
Ah, will do next time. Thanks!
Comment 7 Eric Seidel (no email) 2010-08-09 17:25:34 PDT
Comment on attachment 63940 [details]
Trying again, this time with no tabs :)

Clearing flags on attachment: 63940

Committed r65020: <http://trac.webkit.org/changeset/65020>
Comment 8 Eric Seidel (no email) 2010-08-09 17:25:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Review Bot 2010-08-09 17:45:41 PDT
http://trac.webkit.org/changeset/65020 might have broken Qt Linux Release minimal
The following changes are on the blame list:
http://trac.webkit.org/changeset/65020
http://trac.webkit.org/changeset/65021