Bug 43728 - [Qt] No need for PageClientImpl
Summary: [Qt] No need for PageClientImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 09:54 PDT by Balazs Kelemen
Modified: 2010-08-09 11:01 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (3.76 KB, patch)
2010-08-09 10:01 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-08-09 09:54:42 PDT 
In http://trac.webkit.org/changeset/64122 I have created a PageClientImpl class by moving the WebKit::PageClient implementation from QWKPagePrivate to the new class. The reason of this change is written in bug 42974. However, after http://trac.webkit.org/changeset/64155 the new class has became useless. I think it would be better to take back the change by making QWKPagePrivate the PageClient since it is more logical.
Comment 1 Balazs Kelemen 2010-08-09 10:01:12 PDT 
Created attachment 63905 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2010-08-09 11:01:35 PDT 
Comment on attachment 63905 [details]
proposed patch

Clearing flags on attachment: 63905

Committed r64992: <http://trac.webkit.org/changeset/64992>
Comment 3 Eric Seidel (no email) 2010-08-09 11:01:40 PDT 
All reviewed patches have been landed.  Closing bug.