Bug 43726 - Web Inspector: remove InspectorFrontend
Summary: Web Inspector: remove InspectorFrontend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 09:03 PDT by Yury Semikhatsky
Modified: 2010-08-10 00:27 PDT (History)
14 users (show)

See Also:

Attachments
Patch (19.53 KB, patch)
2010-08-09 09:06 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (18.89 KB, patch)
2010-08-09 09:09 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (20.47 KB, patch)
2010-08-09 22:51 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-08-09 09:03:59 PDT 
Web Inspector: remove InspectorFrontend
Comment 1 Yury Semikhatsky 2010-08-09 09:06:51 PDT 
Created attachment 63898 [details]
Patch
Comment 2 Yury Semikhatsky 2010-08-09 09:09:35 PDT 
Created attachment 63899 [details]
Patch
Comment 3 Pavel Feldman 2010-08-09 09:14:52 PDT 
Comment on attachment 63899 [details]
Patch

LayoutTests/http/tests/inspector/inspector-test.js:39
 +              {
Nit: strange indentation.

LayoutTests/http/tests/inspector-enabled/resources/console-log-frame-after-navigation.html:5
 +  setTimeout(function() {
Does not belong to this change.

WebCore/inspector/InspectorController.cpp:474
 +  void InspectorController::connectFrontend(const ScriptObject&)
Remove this parameter as a whole? r- for this!

WebCore/inspector/InspectorController.cpp:478
 +      m_remoteFrontend = new RemoteInspectorFrontend(m_client);
InspectorFrontend is dead. Long live InspectorFrontend.
In other words: let rename RemoteInspectorFrontend to InspectorFrontend!
Comment 4 WebKit Review Bot 2010-08-09 09:24:54 PDT 
Attachment 63898 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3690060
Comment 5 Yury Semikhatsky 2010-08-09 22:51:17 PDT 
Created attachment 63976 [details]
Patch
Comment 6 Yury Semikhatsky 2010-08-09 22:52:30 PDT 
Addressed all comments.
Comment 7 Early Warning System Bot 2010-08-09 23:04:28 PDT 
Attachment 63976 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3714013
Comment 8 WebKit Review Bot 2010-08-10 00:17:54 PDT 
http://trac.webkit.org/changeset/65053 might have broken Chromium Linux Release
Comment 9 Yury Semikhatsky 2010-08-10 00:27:42 PDT 
Committed r65053