[v8] Create callbacks for named access of elements from document object on fly.
Created attachment 63900 [details] Patch
Nate, as you reviewed original patch, may I ask you to review this one as well?
Comment on attachment 63900 [details] Patch Ok.
Thank you very much, Nate. I won't land this patch immediately though---there might be perf regression and I'd like to check it first. If everything goes all right, I'll land it tomorrow.
Comment on attachment 63900 [details] Patch Perf regression was a false alarm. cq'ing it.
Comment on attachment 63900 [details] Patch Rejecting patch 63900 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Nate Chapin', u'--force']" exit_code: 1 Last 500 characters of output: succeeded at 478 (offset 7 lines). patching file WebCore/bindings/v8/V8DOMWindowShell.cpp patching file WebCore/bindings/v8/V8DOMWindowShell.h Hunk #1 succeeded at 31 with fuzz 2. Hunk #2 FAILED at 42. 1 out of 3 hunks FAILED -- saving rejects to file WebCore/bindings/v8/V8DOMWindowShell.h.rej patching file WebCore/bindings/v8/V8DOMWrapper.cpp patching file WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp patching file WebCore/html/HTMLDocument.cpp Hunk #1 succeeded at 323 (offset -5 lines). Full output: http://queues.webkit.org/results/3777095
Created attachment 64248 [details] rebasing
Comment on attachment 64248 [details] rebasing cq+ after rebaselining
Comment on attachment 64248 [details] rebasing Clearing flags on attachment: 64248 Committed r65284: <http://trac.webkit.org/changeset/65284>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/65284 might have broken Chromium Linux Release
This broke the chromium compile on all platforms. Is anyone fixing it? If not I'm reverting.
Looks like this broke the compile because of incorrect #includes of (Atomic)String.h. Please fix the includes, compile check, and repost this patch.
(In reply to comment #13) > Looks like this broke the compile because of incorrect #includes of (Atomic)String.h. Please fix the includes, compile check, and repost this patch. If nobody cares about the build breakage, I will revert.
Committed r65299: <http://trac.webkit.org/changeset/65299>
Reverted r65299.
http://trac.webkit.org/changeset/65299 might have broken SnowLeopard Intel Release (Tests)
Created attachment 64319 [details] correct include
Sorry everyone---I decided to wait a bit before committing it and in meanwhile AtomicString header got moved. I've adjusted a patch (it builds now fine on my Ubuntu box). I should be available for at least 4 hrs, so if you experience any troubles rolling WebKit, just let me know---the fix should be trivial. Once again sorry for troubles.
Comment on attachment 64319 [details] correct include Clearing flags on attachment: 64319 Committed r65316: <http://trac.webkit.org/changeset/65316>
http://trac.webkit.org/changeset/65316 might have broken SnowLeopard Intel Release (Tests)