Bug 43710 – [Qt] Fix layering violations in qt platform code that crash WebKit2

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Antti Koivisto]

Qt networking code in WebCore casts to WebKit types in a few places. These don't exist with WebKit2 -> crash.

[Antti Koivisto]

Created attachment 63872 [details]
patch

[WebKit Review Bot]

Attachment 63872 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/network/qt/ResourceRequest.h:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Rohde Christiansen]

Comment on attachment 63872 [details]
patch

Jesus has been looking into fixing this in a more generic way together with Darin Adler. Can you please consult with him?

[Antti Koivisto]

What are the benefits of this more generic fix? This is not complicated stuff.

[Jesus Sanchez-Palencia]

(In reply to comment #4)
> What are the benefits of this more generic fix? This is not complicated stuff.

The generic solution is being developed at https://bugs.webkit.org/show_bug.cgi?id=42292 .
The benefits of it are solving all the problems we have now in a way that we stay clear of layering violations and that can be easily expanded whenever needed without having to add anything else to the FrameLoaderClient. Moreover, we solve the problem for all WebKit's ports.

[Antonio Gomes]

Imho, I think the general approach is the way to go too. Darin has justified the general approach pretty much.

[Antti Koivisto]

ok, ok :)

*** This bug has been marked as a duplicate of bug 42292 ***