Bug 43710 - [Qt] Fix layering violations in qt platform code that crash WebKit2
Summary: [Qt] Fix layering violations in qt platform code that crash WebKit2
Status: RESOLVED DUPLICATE of bug 42292
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-08-09 02:03 PDT by Antti Koivisto
Modified: 2010-08-10 02:41 PDT (History)
6 users (show)

See Also:

Attachments
patch (12.67 KB, patch)
2010-08-09 02:08 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2010-08-09 02:03:13 PDT 
Qt networking code in WebCore casts to WebKit types in a few places. These don't exist with WebKit2 -> crash.
Comment 1 Antti Koivisto 2010-08-09 02:08:48 PDT 
Created attachment 63872 [details]
patch
Comment 2 WebKit Review Bot 2010-08-09 02:11:06 PDT 
Attachment 63872 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/network/qt/ResourceRequest.h:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kenneth Rohde Christiansen 2010-08-09 08:20:10 PDT 
Comment on attachment 63872 [details]
patch

Jesus has been looking into fixing this in a more generic way together with Darin Adler. Can you please consult with him?
Comment 4 Antti Koivisto 2010-08-09 09:05:13 PDT 
What are the benefits of this more generic fix? This is not complicated stuff.
Comment 5 Jesus Sanchez-Palencia 2010-08-09 10:16:33 PDT 
(In reply to comment #4)
> What are the benefits of this more generic fix? This is not complicated stuff.

The generic solution is being developed at https://bugs.webkit.org/show_bug.cgi?id=42292 .
The benefits of it are solving all the problems we have now in a way that we stay clear of layering violations and that can be easily expanded whenever needed without having to add anything else to the FrameLoaderClient. Moreover, we solve the problem for all WebKit's ports.
Comment 6 Antonio Gomes 2010-08-09 10:20:11 PDT 
Imho, I think the general approach is the way to go too. Darin has justified the general approach pretty much.
Comment 7 Antti Koivisto 2010-08-10 02:41:08 PDT 
ok, ok :)

*** This bug has been marked as a duplicate of bug 42292 ***