Bug 43698 - Web Inspector: Fix warning in WebCore/inspector/InspectorDebuggerAgent.cpp
Summary: Web Inspector: Fix warning in WebCore/inspector/InspectorDebuggerAgent.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 43191
  Show dependency tree / graph
 
Reported: 2010-08-08 16:50 PDT by Csaba Osztrogonác
Modified: 2010-08-08 22:44 PDT (History)
2 users (show)

See Also:

Attachments
proposed fix (1.38 KB, patch)
2010-08-08 16:54 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-08-08 16:50:32 PDT 
gcc warning:
../../../WebCore/inspector/InspectorDebuggerAgent.cpp:132: warning: suggest parentheses around assignment used as truth value

This warning introduced in http://trac.webkit.org/changeset/64846 .
Comment 1 Csaba Osztrogonác 2010-08-08 16:54:12 PDT 
Created attachment 63852 [details]
proposed fix
Comment 2 Antonio Gomes 2010-08-08 19:34:08 PDT 
Comment on attachment 63852 [details]
proposed fix

You can either do it this way, or make perform the assignment before the if statement (which I personally would had done.).

Either way is fine with me.
Comment 3 Csaba Osztrogonác 2010-08-08 22:43:57 PDT 
Comment on attachment 63852 [details]
proposed fix

Clearing flags on attachment: 63852

Committed r64964: <http://trac.webkit.org/changeset/64964>
Comment 4 Csaba Osztrogonác 2010-08-08 22:44:05 PDT 
All reviewed patches have been landed.  Closing bug.