Bug 43695 - [Qt] Inconsistent Qt version checks
Summary: [Qt] Inconsistent Qt version checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ariya Hidayat
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-08-08 12:09 PDT by Ariya Hidayat
Modified: 2010-08-08 22:50 PDT (History)
0 users

See Also:

Attachments
Patch (14.04 KB, patch)
2010-08-08 12:16 PDT, Ariya Hidayat 		tonikitoo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2010-08-08 12:09:52 PDT 
Inconsistent Qt version checks
Comment 1 Ariya Hidayat 2010-08-08 12:12:14 PDT 
Some are using the encoded hex, some others are using QT_VERSION_CHECK macro.

Will upload a patch.
Comment 2 Ariya Hidayat 2010-08-08 12:16:07 PDT 
Created attachment 63848 [details]
Patch
Comment 3 Antonio Gomes 2010-08-08 19:23:16 PDT 
Comment on attachment 63848 [details]
Patch

r=me
Comment 4 Ariya Hidayat 2010-08-08 22:50:00 PDT 
Manually committed r64965: http://trac.webkit.org/changeset/64965