Bug 43690 - [GTK] DRT on GTK reports different frame names from other platforms
Summary: [GTK] DRT on GTK reports different frame names from other platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-08-08 10:01 PDT by Mihai Parparita
Modified: 2013-03-15 03:30 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-08-08 10:01:53 PDT
This layout test:

http://trac.webkit.org/browser/trunk/LayoutTests/fast/events/script-tests/onunload-back-to-page-cache.js?rev=64939

Sets window.name to 'navigated' before navigating to a page with an onunload handler. Mac (and other platform) DRT prints this message:

main frame "navigated" - has 1 onunload handler(s)

While GTK DRT prints this message:

main frame - has 1 onunload handler(s)

Presumably getFrameNameSuitableForTestResult in WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp should be brought closer to _drt_descriptionSuitableForTestResult in WebKitTools/DumpRenderTree/mac/FrameLoadDelegate.mm
Comment 1 Martin Robinson 2010-08-09 09:24:08 PDT
I don't see this problem locally. When I revert the change you made in r64953, I get a failure, because "navigated" is listed in the output. Can you recall if this was failing on all bots or just some of them? Perhaps it's another timing issue.
Comment 2 Mihai Parparita 2010-08-09 09:56:03 PDT
I only happened to check the GTK Linux 64-bit Debug bot, but it seemed to be failing consistently. If you revert r64953 (for both the test and the expected output) and get a failure, doesn't that mean that you can reproduce this? "navigated" should be in the output in that case (and did appear to show up in all the other bots).
Comment 3 Zan Dobersek 2013-03-15 03:30:22 PDT
This test doesn't fail anymore on any platform, it seems though all the ports are now outputting the onunload handler report without the frame name.
http://trac.webkit.org/browser/trunk/LayoutTests/fast/events/onunload-back-to-page-cache-expected.txt