Bug 43684 - Add additional loader client functions need to complete WebKitTestRunner
Summary: Add additional loader client functions need to complete WebKitTestRunner
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-08-07 16:07 PDT by Sam Weinig
Modified: 2010-08-07 16:26 PDT (History)
1 user (show)

See Also:

Patch (39.29 KB, patch)
2010-08-07 16:09 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-08-07 16:07:27 PDT
We need a few more callbacks.
Comment 1 Sam Weinig 2010-08-07 16:09:11 PDT
Created attachment 63834 [details]
Comment 2 WebKit Review Bot 2010-08-07 16:10:39 PDT
Attachment 63834 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:80:  Extra space between WKBundlePageDidCancelClientRedirectForFrameCallback and didCancelClientRedirectForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:81:  Extra space between WKBundlePageWillPerformClientRedirectForFrameCallback and willPerformClientRedirectForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:82:  Extra space between WKBundlePageDidChangeLocationWithinPageForFrameCallback and didChangeLocationWithinPageForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:83:  Extra space between WKBundlePageDidFinishDocumentLoadForFrameCallback and didFinishDocumentLoadForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:84:  Extra space between WKBundlePageDidHandleOnloadEventsForFrameCallback and didHandleOnloadEventsForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:85:  Extra space between WKBundlePageDidDisplayInsecureContentForFrameCallback and didDisplayInsecureContentForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:86:  Extra space between WKBundlePageDidRunInsecureContentForFrameCallback and didRunInsecureContentForFrame  [whitespace/declaration] [3]
Total errors found: 7 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-08-07 16:26:31 PDT
Landed in r64927.