RESOLVED FIXED 43684
Add additional loader client functions need to complete WebKitTestRunner 
https://bugs.webkit.org/show_bug.cgi?id=43684
Summary Add additional loader client functions need to complete WebKitTestRunner
Sam Weinig
Reported 2010-08-07 16:07:27 PDT
We need a few more callbacks.
Attachments
Patch (39.29 KB, patch)
2010-08-07 16:09 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-08-07 16:09:11 PDT
Created attachment 63834 [details] Patch
WebKit Review Bot
Comment 2 2010-08-07 16:10:39 PDT
Attachment 63834 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:80: Extra space between WKBundlePageDidCancelClientRedirectForFrameCallback and didCancelClientRedirectForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:81: Extra space between WKBundlePageWillPerformClientRedirectForFrameCallback and willPerformClientRedirectForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:82: Extra space between WKBundlePageDidChangeLocationWithinPageForFrameCallback and didChangeLocationWithinPageForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:83: Extra space between WKBundlePageDidFinishDocumentLoadForFrameCallback and didFinishDocumentLoadForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:84: Extra space between WKBundlePageDidHandleOnloadEventsForFrameCallback and didHandleOnloadEventsForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:85: Extra space between WKBundlePageDidDisplayInsecureContentForFrameCallback and didDisplayInsecureContentForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:86: Extra space between WKBundlePageDidRunInsecureContentForFrameCallback and didRunInsecureContentForFrame [whitespace/declaration] [3] Total errors found: 7 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-08-07 16:26:31 PDT
Landed in r64927.
Note You need to log in before you can comment on or make changes to this bug.