Bug 43674 - Create a separate SimpleFontData constructor for SVG fonts and move the CTFontRef member to platform data
Summary: Create a separate SimpleFontData constructor for SVG fonts and move the CTFon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-07 11:53 PDT by mitz
Modified: 2010-08-08 10:48 PDT (History)
5 users (show)

See Also:


Attachments
Create a separate SimpleFontData constructor for SVG fonts and move the CTFontRef member to platform dat (26.42 KB, patch)
2010-08-07 11:54 PDT, mitz
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2010-08-07 11:53:12 PDT
Patch forthcoming.
Comment 1 mitz 2010-08-07 11:54:03 PDT
Created attachment 63823 [details]
Create a separate SimpleFontData constructor for SVG fonts and move the CTFontRef member to platform dat
Comment 3 WebKit Review Bot 2010-08-07 12:07:08 PDT
http://trac.webkit.org/changeset/64915 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
Comment 4 Early Warning System Bot 2010-08-07 12:11:37 PDT
Attachment 63823 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3674039
Comment 5 Dimitri Glazkov (Google) 2010-08-08 07:59:45 PDT
This broke Chromium Mac: http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/11836/steps/compile-webkit/logs/stdio

Haven't yet looked at the details, just noticed.
Comment 6 mitz 2010-08-08 09:42:18 PDT
(In reply to comment #5)
> This broke Chromium Mac: http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/11836/steps/compile-webkit/logs/stdio
> 
> Haven't yet looked at the details, just noticed.

Thanks. I committed r64950 in an attempt to fix it.
Comment 7 Dimitri Glazkov (Google) 2010-08-08 10:48:28 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > This broke Chromium Mac: http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/11836/steps/compile-webkit/logs/stdio
> > 
> > Haven't yet looked at the details, just noticed.
> 
> Thanks. I committed r64950 in an attempt to fix it.

It worked, yay! Thanks mitz.