RESOLVED INVALID 43660
GraphicsContext3D::create should take a Page, not a HostWindow 
https://bugs.webkit.org/show_bug.cgi?id=43660
Summary GraphicsContext3D::create should take a Page, not a HostWindow
James Robinson
Reported 2010-08-06 18:33:49 PDT
GraphicsContext3D::create should take a Page, not a HostWindow
Attachments
Patch (22.07 KB, patch)
2010-08-06 18:37 PDT, James Robinson 		sam: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-08-06 18:37:54 PDT
Created attachment 63792 [details] Patch
Sam Weinig
Comment 2 2010-08-06 22:32:20 PDT
Comment on attachment 63792 [details] Patch This seems like the wrong direction. Taking a Page* would be a layering violation. Why is this necessary? Also, you are missing a ChangeLog. (Also, why is chromium GraphicsContext3D in WebKit/chromium and not in WebCore/platform?) r-.
James Robinson
Comment 3 2010-08-08 12:13:40 PDT
Good point! Closing this out, was a bad idea :)
Note You need to log in before you can comment on or make changes to this bug.