Bug 43660 - GraphicsContext3D::create should take a Page, not a HostWindow
Summary: GraphicsContext3D::create should take a Page, not a HostWindow
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-06 18:33 PDT by James Robinson
Modified: 2010-08-08 12:13 PDT (History)
2 users (show)

See Also:

Attachments
Patch (22.07 KB, patch)
2010-08-06 18:37 PDT, James Robinson 		sam: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-08-06 18:33:49 PDT 
GraphicsContext3D::create should take a Page, not a HostWindow
Comment 1 James Robinson 2010-08-06 18:37:54 PDT 
Created attachment 63792 [details]
Patch
Comment 2 Sam Weinig 2010-08-06 22:32:20 PDT 
Comment on attachment 63792 [details]
Patch

This seems like the wrong direction. Taking a Page* would be a layering violation.  Why is this necessary?  Also, you are missing a ChangeLog.  (Also, why is chromium GraphicsContext3D in WebKit/chromium and not in WebCore/platform?) r-.
Comment 3 James Robinson 2010-08-08 12:13:40 PDT 
Good point!  Closing this out, was a bad idea :)