RESOLVED FIXED 43657
Fix style violations in Document 
https://bugs.webkit.org/show_bug.cgi?id=43657
Summary Fix style violations in Document
Tony Gentilcore
Reported 2010-08-06 17:27:43 PDT
Fix style violations in Document
Attachments
Patch (33.00 KB, patch)
2010-08-06 17:33 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-08-06 17:33:25 PDT
Created attachment 63789 [details] Patch
Adam Barth
Comment 2 2010-08-06 18:02:20 PDT
Comment on attachment 63789 [details] Patch Looks great. Thanks Tony.
Adam Barth
Comment 3 2010-08-06 18:30:26 PDT
Comment on attachment 63789 [details] Patch Clearing flags on attachment: 63789 Committed r64889: <http://trac.webkit.org/changeset/64889>
Adam Barth
Comment 4 2010-08-06 18:30:32 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2010-08-06 23:30:03 PDT
case PROCESSING_INSTRUCTION_NODE: - return true; + break; Was this a style violation?
Tony Gentilcore
Comment 6 2010-08-07 09:29:23 PDT
(In reply to comment #5) > case PROCESSING_INSTRUCTION_NODE: > - return true; > + break; > > Was this a style violation? Sharp eye. This didn't actually change, the diff is just really misleading. There are actually two switch statements: the first on line 2591, the second on line 2614. They are identical except for indentation and this one case. My change only fixed the indentation of both switches. However, rather than making it look like I changed two switch statements, the diff made it look like I deleted the first, changed the second into the first and added a new one. Anyway, looking at the full file instead of the diff should hopefully clear this up.
Note You need to log in before you can comment on or make changes to this bug.