WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43653
WebKitTestRunner should be more aggressive about ensuring consistent state between tests
https://bugs.webkit.org/show_bug.cgi?id=43653
Summary
WebKitTestRunner should be more aggressive about ensuring consistent state be...
Sam Weinig
Reported
2010-08-06 16:29:21 PDT
WebKitTestRunner should be more aggressive about ensuring consistent state between tests. For instance, it should ensure that there are no outstanding loads, all windows other than the main window are closed and the web process is alive.
Attachments
Patch
(33.24 KB, patch)
2010-08-11 19:57 PDT
,
Sam Weinig
sam
: review-
Details
Formatted Diff
Diff
Patch 2
(32.80 KB, patch)
2010-08-11 23:08 PDT
,
Sam Weinig
ap
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2010-08-06 16:29:49 PDT
<
rdar://problem/8283644
>
Sam Weinig
Comment 2
2010-08-11 19:57:45 PDT
Created
attachment 64181
[details]
Patch
Sam Weinig
Comment 3
2010-08-11 22:45:48 PDT
Comment on
attachment 64181
[details]
Patch r-ing for now, there is something weird in here.
Alexey Proskuryakov
Comment 4
2010-08-11 23:00:45 PDT
> + WKRetainPtr<WKURLRef> url(AdoptWK, createWKURL("about:blank")); > + WKPageLoadURL(m_mainWebView->page(), url.get());
It seems that this can affect performance a lot. DRT doesn't do that, does it?
Sam Weinig
Comment 5
2010-08-11 23:06:17 PDT
(In reply to
comment #4
)
> > + WKRetainPtr<WKURLRef> url(AdoptWK, createWKURL("about:blank")); > > + WKPageLoadURL(m_mainWebView->page(), url.get()); > > It seems that this can affect performance a lot. DRT doesn't do that, does it?
DRT does, [mainFrame loadHTMLString:@"<html></html>" baseURL:[NSURL URLWithString:@"about:blank"]]; [mainFrame stopLoading]; in runTest(). I am not sure how much that differs in performance, but since we don't have that mechanism yet, I thought this would do nicely.
Sam Weinig
Comment 6
2010-08-11 23:08:32 PDT
Created
attachment 64188
[details]
Patch 2
Sam Weinig
Comment 7
2010-08-12 14:28:39 PDT
Landed in
r65267
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug