WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43646
[CHROMIUM] Prefer the medium-quality (bilinear) image resampling for 2D canvas.
https://bugs.webkit.org/show_bug.cgi?id=43646
Summary
[CHROMIUM] Prefer the medium-quality (bilinear) image resampling for 2D canvas.
Stephen White
Reported
2010-08-06 15:00:28 PDT
[CHROMIUM] Prefer the medium-quality (bilinear) image resampling for 2D canvas.
Attachments
Patch
(2.42 KB, patch)
2010-08-06 15:10 PDT
,
Stephen White
no flags
Details
Formatted Diff
Diff
Patch
(3.15 KB, patch)
2010-08-09 11:02 PDT
,
Stephen White
levin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Stephen White
Comment 1
2010-08-06 15:10:27 PDT
Created
attachment 63765
[details]
Patch
Sam Weinig
Comment 2
2010-08-06 22:40:50 PDT
Is there a way to do this without throwing an #ifdef in the middle of that file? Is this something other ports should consider?
Stephen White
Comment 3
2010-08-07 04:52:23 PDT
(In reply to
comment #2
)
> Is there a way to do this without throwing an #ifdef in the middle of that file? Is this something other ports should consider?
Another way it could be done would be to define a "CanvasImageInterpolationQuality" in graphics.h, which could be #defined'ed by each platform. Then at least the platform #if would be in platform/graphics, rather than here at this level. Whether other ports want to do it is really up to their maintainers -- the canvas spec does not specify any particular algorithm for image resampling.
Stephen White
Comment 4
2010-08-09 11:02:59 PDT
Created
attachment 63909
[details]
Patch
Stephen White
Comment 5
2010-08-09 11:03:51 PDT
(In reply to
comment #4
)
> Created an attachment (id=63909) [details] > Patch
Here's a version with the platform-specific stuff pushed into GraphicsContext.h.
Stephen White
Comment 6
2010-08-10 15:02:54 PDT
Committed
r65097
: <
http://trac.webkit.org/changeset/65097
>
WebKit Review Bot
Comment 7
2010-08-10 17:02:19 PDT
http://trac.webkit.org/changeset/65097
might have broken GTK Linux 32-bit Release
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug