Bug 43644 - [chromium] GraphicsContext3D should bypass the software rendering path when doing accelerated compositing
Summary: [chromium] GraphicsContext3D should bypass the software rendering path when d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Vangelis Kokkevis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-06 14:29 PDT by Vangelis Kokkevis
Modified: 2010-08-09 10:40 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (2.76 KB, patch)
2010-08-06 15:14 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-08-06 14:29:05 PDT 
As the code currently stands, during gpu compositing, the graphics layer corresponding to a WebGL context can be asked to render its contents into a canvas backed GraphicsContext, resulting in an expensive GL readback operation that's not necessary. In the chromium code this happens when calling GraphicsContext3D::beginPaint() which was implemented for the software compositing path.
Comment 1 Vangelis Kokkevis 2010-08-06 15:14:25 PDT 
Created attachment 63767 [details]
Proposed patch
Comment 2 Dimitri Glazkov (Google) 2010-08-09 10:15:02 PDT 
Comment on attachment 63767 [details]
Proposed patch

ok.
Comment 3 Eric Seidel (no email) 2010-08-09 10:39:58 PDT 
Comment on attachment 63767 [details]
Proposed patch

Clearing flags on attachment: 63767

Committed r64990: <http://trac.webkit.org/changeset/64990>
Comment 4 Eric Seidel (no email) 2010-08-09 10:40:03 PDT 
All reviewed patches have been landed.  Closing bug.