RESOLVED FIXED Bug 43643
Detect invalid CoreIPC messages and call didReceiveInvalidMessage 
https://bugs.webkit.org/show_bug.cgi?id=43643
Summary Detect invalid CoreIPC messages and call didReceiveInvalidMessage
Anders Carlsson
Reported 2010-08-06 14:27:53 PDT
Detect invalid CoreIPC messages and call didReceiveInvalidMessage
Attachments
Patch (8.89 KB, patch)
2010-08-06 14:37 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-08-06 14:37:09 PDT
Created attachment 63761 [details] Patch
Anders Carlsson
Comment 2 2010-08-06 14:37:25 PDT
<rdar://problem/7891069>
Adam Roben (:aroben)
Comment 3 2010-08-06 14:44:25 PDT
Comment on attachment 63761 [details] Patch > @@ -253,14 +257,15 @@ void Connection::dispatchMessages() > OwnPtr<ArgumentEncoder> replyEncoder(new ArgumentEncoder(syncRequestID)); > > // Hand off both the decoder and encoder to the client.. > - m_client->didReceiveSyncMessage(this, message.messageID(), arguments, replyEncoder.get()); > + m_client->didReceiveSyncMessage(this, message.messageID(), arguments.get(), replyEncoder.get()); > > // Send the reply. > sendMessage(MessageID(CoreIPCMessage::SyncMessageReply), replyEncoder.release()); > } else > - m_client->didReceiveMessage(this, message.messageID(), arguments); > + m_client->didReceiveMessage(this, message.messageID(), arguments.get()); > > - message.destroy(); > + if (arguments->isInvalid()) > + m_client->didReceiveInvalidMessage(this, message.messageID()); > } > } Should we check if the arguments are invalid before sending the synchronous reply? r=me
Anders Carlsson
Comment 4 2010-08-06 14:53:20 PDT
Committed r64871: <http://trac.webkit.org/changeset/64871>
Note You need to log in before you can comment on or make changes to this bug.